From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elena Zannoni To: David Taylor Cc: gdb-patches@sources.redhat.com, ezannoni@cygnus.com Subject: Re: [RFA] symtab.c (search_symbols) -- fix off by one error Date: Mon, 19 Feb 2001 16:00:00 -0000 Message-id: <14993.45970.145792.634625@kwikemart.cygnus.com> References: <200102192059.PAA18068@texas.cygnus.com> X-SW-Source: 2001-02/msg00392.html Background: I pinged David to check the status of this patch: http://sources.redhat.com/ml/gdb-patches/2000-08/msg00290.html (which occurred in my list of pending patches). The patch had been committed but prompted for a second review of the code, and the following patch was the result. OK, this patch can be committed. Thanks Elena David Taylor writes: > ChangeLog entry: > > * symtab.c (search_symbols): Fix off by one error in test for > error. > > Index: symtab.c > =================================================================== > RCS file: /cvs/src/src/gdb/symtab.c,v > retrieving revision 1.28 > diff -c -r1.28 symtab.c > *** symtab.c 2001/01/30 02:49:36 1.28 > --- symtab.c 2001/02/19 20:55:43 > *************** > *** 2348,2354 **** > struct symbol_search *tail; > struct cleanup *old_chain = NULL; > > ! if (kind < LABEL_NAMESPACE) > error ("must search on specific namespace"); > > ourtype = types[(int) (kind - VARIABLES_NAMESPACE)]; > --- 2348,2354 ---- > struct symbol_search *tail; > struct cleanup *old_chain = NULL; > > ! if (kind < VARIABLES_NAMESPACE) > error ("must search on specific namespace"); > > ourtype = types[(int) (kind - VARIABLES_NAMESPACE)]; >