[PATCH v2] Call remote_check_symbols() even if only symbol-file (not file) has been given

[PATCH v2] Call remote_check_symbols() even if only symbol-file (not file) has been given

[Christian Eggers]

The Eclipse "C/C++ GDB Hardware Debugging" plugin runs only 
the "symbol-file" command. In this case, remote_check_symbols()
is not called and no qSymbol:: packet is sent to the gdbserver
(OpenOCD in my case).

v2:
- Line wrap changelog
- spelling ("an" --> "a")

2014-02-01  Christian Eggers  <ceggers@gmx.de>

	* remote.c (remote_start_remote): Call remote_check_symbols() 
	even if only symbol-file (not file) has been given.


diff --git a/gdb/remote.c b/gdb/remote.c
index 7297df0..40cc143 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -3668,7 +3668,7 @@ remote_start_remote (int from_tty, struct target_ops 
*target, int extended_p)
   /* If we connected to a live target, do some additional setup.  */
   if (target_has_execution)
     {
-      if (exec_bfd) 	/* No use without an exec file.  */
+      if (symfile_objfile) 	/* No use without a symbol-file.  */
 	remote_check_symbols ();
     }
 

Re: [PATCH v2] Call remote_check_symbols() even if only symbol-file (not file) has been given

[Pedro Alves]

On 02/03/2014 05:36 AM, Christian Eggers wrote:
> The Eclipse "C/C++ GDB Hardware Debugging" plugin runs only 
> the "symbol-file" command. In this case, remote_check_symbols()
> is not called and no qSymbol:: packet is sent to the gdbserver
> (OpenOCD in my case).

Looks good to me.  I've pushed it, as below.  The "tiny change"
marker is just an indication that the patch was small
enough to not require copyright assignment.  If you'd like
to contribute more changes, contact me offlist, and I'll get
you started on the process.

Thanks!

P.S.: The qSymbol lookup iterates over all object_files.  ISTM
we could check if that list is empty instead of checking
for symfile_objfile explicitly, but I didn't want to force
another patch iteration until there's a need for that.


---------
From: Christian Eggers <ceggers@gmx.de>
Subject: [PATCH] Call remote_check_symbols even if only symbol-file (not
 file) has been given

The Eclipse "C/C++ GDB Hardware Debugging" plugin runs only the
"symbol-file" command.  In this case, remote_check_symbols is not
called and no qSymbol:: packet is sent to the server (OpenOCD in my
case).

gdb/
2014-02-04  Christian Eggers  <ceggers@gmx.de>  (tiny change)

	* remote.c (remote_start_remote): Call remote_check_symbols even
	if only symbol-file (not file) has been given.
---
 gdb/ChangeLog | 5 +++++
 gdb/remote.c  | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 9f4636f..8cd059f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2014-02-04  Christian Eggers  <ceggers@gmx.de>  (tiny change)
+
+	* remote.c (remote_start_remote): Call remote_check_symbols even
+	if only symbol-file (not file) has been given.
+
 2014-02-04  Ulrich Weigand  <uweigand@de.ibm.com>
 
 	* gdbarch.sh (skip_entrypoint): New callback.
diff --git a/gdb/remote.c b/gdb/remote.c
index 7297df0..4227ed5 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -3668,7 +3668,7 @@ remote_start_remote (int from_tty, struct target_ops *target, int extended_p)
   /* If we connected to a live target, do some additional setup.  */
   if (target_has_execution)
     {
-      if (exec_bfd) 	/* No use without an exec file.  */
+      if (symfile_objfile) 	/* No use without a symbol-file.  */
 	remote_check_symbols ();
     }
 
-- 
1.7.11.7