From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8691 invoked by alias); 4 Feb 2014 19:55:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8674 invoked by uid 89); 4 Feb 2014 19:55:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Feb 2014 19:55:06 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s14JswUh025914 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 4 Feb 2014 14:54:58 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s14JssTM022478; Tue, 4 Feb 2014 14:54:55 -0500 Message-ID: <52F1458E.5050907@redhat.com> Date: Tue, 04 Feb 2014 19:55:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Christian Eggers CC: gdb-patches@sourceware.org, Yao Qi Subject: Re: [PATCH v2] Call remote_check_symbols() even if only symbol-file (not file) has been given References: <1965657.Noj9pa4IVT@p2130> In-Reply-To: <1965657.Noj9pa4IVT@p2130> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-02/txt/msg00026.txt.bz2 On 02/03/2014 05:36 AM, Christian Eggers wrote: > The Eclipse "C/C++ GDB Hardware Debugging" plugin runs only > the "symbol-file" command. In this case, remote_check_symbols() > is not called and no qSymbol:: packet is sent to the gdbserver > (OpenOCD in my case). Looks good to me. I've pushed it, as below. The "tiny change" marker is just an indication that the patch was small enough to not require copyright assignment. If you'd like to contribute more changes, contact me offlist, and I'll get you started on the process. Thanks! P.S.: The qSymbol lookup iterates over all object_files. ISTM we could check if that list is empty instead of checking for symfile_objfile explicitly, but I didn't want to force another patch iteration until there's a need for that. --------- From: Christian Eggers Subject: [PATCH] Call remote_check_symbols even if only symbol-file (not file) has been given The Eclipse "C/C++ GDB Hardware Debugging" plugin runs only the "symbol-file" command. In this case, remote_check_symbols is not called and no qSymbol:: packet is sent to the server (OpenOCD in my case). gdb/ 2014-02-04 Christian Eggers (tiny change) * remote.c (remote_start_remote): Call remote_check_symbols even if only symbol-file (not file) has been given. --- gdb/ChangeLog | 5 +++++ gdb/remote.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 9f4636f..8cd059f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2014-02-04 Christian Eggers (tiny change) + + * remote.c (remote_start_remote): Call remote_check_symbols even + if only symbol-file (not file) has been given. + 2014-02-04 Ulrich Weigand * gdbarch.sh (skip_entrypoint): New callback. diff --git a/gdb/remote.c b/gdb/remote.c index 7297df0..4227ed5 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -3668,7 +3668,7 @@ remote_start_remote (int from_tty, struct target_ops *target, int extended_p) /* If we connected to a live target, do some additional setup. */ if (target_has_execution) { - if (exec_bfd) /* No use without an exec file. */ + if (symfile_objfile) /* No use without a symbol-file. */ remote_check_symbols (); } -- 1.7.11.7