From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18268 invoked by alias); 3 Feb 2014 05:36:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18256 invoked by uid 89); 3 Feb 2014 05:36:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mout.gmx.net Received: from mout.gmx.net (HELO mout.gmx.net) (212.227.17.22) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 03 Feb 2014 05:36:29 +0000 Received: from p2130.localnet ([87.163.55.180]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0Mb7lL-1VpdBL2k2d-00KirS for ; Mon, 03 Feb 2014 06:36:25 +0100 From: Christian Eggers To: gdb-patches@sourceware.org Cc: Pedro Alves , Yao Qi Subject: [PATCH v2] Call remote_check_symbols() even if only symbol-file (not file) has been given Date: Mon, 03 Feb 2014 05:36:00 -0000 Message-ID: <1965657.Noj9pa4IVT@p2130> User-Agent: KMail/4.11.4 (Linux/3.11.6-4-desktop; KDE/4.11.4; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2014-02/txt/msg00012.txt.bz2 The Eclipse "C/C++ GDB Hardware Debugging" plugin runs only the "symbol-file" command. In this case, remote_check_symbols() is not called and no qSymbol:: packet is sent to the gdbserver (OpenOCD in my case). v2: - Line wrap changelog - spelling ("an" --> "a") 2014-02-01 Christian Eggers * remote.c (remote_start_remote): Call remote_check_symbols() even if only symbol-file (not file) has been given. diff --git a/gdb/remote.c b/gdb/remote.c index 7297df0..40cc143 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -3668,7 +3668,7 @@ remote_start_remote (int from_tty, struct target_ops *target, int extended_p) /* If we connected to a live target, do some additional setup. */ if (target_has_execution) { - if (exec_bfd) /* No use without an exec file. */ + if (symfile_objfile) /* No use without a symbol-file. */ remote_check_symbols (); }