Re: [PATCH v6] Change message when reaching end of reverse history.

[Guinevere Larsen <blarsen@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 4057 bytes --]

Pushed :)
though, I'm very sorry, I messed up some git command and ended up as the 
author, and only realized after the push. I don't think there's a way to 
amend it once it's pushed :(

-- 
Cheers,
Guinevere Larsen
She/Her/Hers

On 8/23/24 9:25 AM, Alex Chronopoulos wrote:
> Since it takes some time, could you go on and land this one? I will 
> have coordinated with Tom by the next time it's needed.
>
> On Tue, Aug 13, 2024 at 9:26 PM Guinevere Larsen <blarsen@redhat.com> 
> wrote:
>
>     I'm CC-ing Tom Tromey, as he's the one who usually talks about
>     this in the list. Tom, Could you take care of this?
>
>     -- 
>     Cheers,
>     Guinevere Larsen
>     She/Her/Hers
>
>     On 8/13/24 3:18 PM, Alex Chronopoulos wrote:
>>     Hooray \o/
>>     Thank you for the reviews.
>>     I would like to push myself, how can I get write-after-approval
>>     rights?
>>
>>     On Tue, Aug 13, 2024 at 2:55 PM Guinevere Larsen
>>     <blarsen@redhat.com> wrote:
>>
>>         On 8/13/24 5:52 AM, Metzger, Markus T wrote:
>>         > Hello Alex,
>>         >
>>         >>> In a record session, when we move backward, GDB switches
>>         from normal
>>         >>> execution to simulation. Moving forward again, the
>>         emulation continues
>>         >>> until the end of the reverse history. When the end is
>>         reached, the
>>         >>> execution stops, and a warning message is shown. This
>>         message has been
>>         >>> modified to indicate that the forward emulation has
>>         reached the end, but
>>         >>> the execution can continue as normal, and the recording
>>         will also continue.
>>         >>>
>>         >>> Before this patch, the warning message shown in that case
>>         was the same as
>>         >>> in the reverse case. This meant that when the end of
>>         history was reached in
>>         >>> either backward or forward emulation, the same message
>>         was displayed:
>>         >>>
>>         >>> "No more reverse-execution history."
>>         >>>
>>         >>> This message has changed for these two cases. Backward
>>         emulation:
>>         >>>
>>         >>> "Reached end of recorded history; stopping.
>>         >>> Backward execution from here not possible."
>>         >>>
>>         >>> Forward emulation:
>>         >>>
>>         >>> "Reached end of recorded history; stopping.
>>         >>> Following forward execution will be added to history."
>>         >>>
>>         >>> The reason for this change is that the initial message
>>         was deceiving, for
>>         >>> the forward case, making the user believe that forward
>>         debugging could not
>>         >>> continue.
>>         >>>
>>         >>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31224
>>         >>> ---
>>         >> Hi! I think this is good to go in, but I would like Markus
>>         to chime in
>>         >> before pushing, since he mantains the other record
>>         subsystem, so for now
>>         >>
>>         >> Reviewed-By: Guinevere Larsen <blarsen@redhat.com>
>>         > OK for btrace.
>>
>>         Awesome! Alex, feel free to change my tag to: Approved-By:
>>         Guinevere
>>         Larsen <blarsen@redhat.com>
>>
>>         Do you already have write after approval rights for the repo?
>>         If not, do
>>         you plan to send more patches, so it makes sense to go after
>>         it? If not,
>>         I can push this for you :)
>>
>>         -- 
>>         Cheers,
>>         Guinevere Larsen
>>         She/Her/Hers
>>
>>         >
>>         > Markus.
>>         > Intel Deutschland GmbH
>>         > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
>>         > Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
>>         > Managing Directors: Sean Fennelly, Jeffrey Schneiderman,
>>         Tiffany Doon Silva
>>         > Chairperson of the Supervisory Board: Nicole Lau
>>         > Registered Office: Munich
>>         > Commercial Register: Amtsgericht Muenchen HRB 186928
>>

[-- Attachment #2: Type: text/html, Size: 8037 bytes --]