Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Alex Chronopoulos <achronop@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	"Guinevere Larsen" <blarsen@redhat.com>
Subject: RE: [PATCH v6] Change message when reaching end of reverse history.
Date: Tue, 13 Aug 2024 08:52:58 +0000	[thread overview]
Message-ID: <DM8PR11MB5749ED2D6C5FDD284440F999DE862@DM8PR11MB5749.namprd11.prod.outlook.com> (raw)
In-Reply-To: <9388437d-557d-45df-8513-d0a91a8e97a7@redhat.com>

Hello Alex,

>> In a record session, when we move backward, GDB switches from normal
>> execution to simulation. Moving forward again, the emulation continues
>> until the end of the reverse history. When the end is reached, the
>> execution stops, and a warning message is shown. This message has been
>> modified to indicate that the forward emulation has reached the end, but
>> the execution can continue as normal, and the recording will also continue.
>>
>> Before this patch, the warning message shown in that case was the same as
>> in the reverse case. This meant that when the end of history was reached in
>> either backward or forward emulation, the same message was displayed:
>>
>> "No more reverse-execution history."
>>
>> This message has changed for these two cases. Backward emulation:
>>
>> "Reached end of recorded history; stopping.
>> Backward execution from here not possible."
>>
>> Forward emulation:
>>
>> "Reached end of recorded history; stopping.
>> Following forward execution will be added to history."
>>
>> The reason for this change is that the initial message was deceiving, for
>> the forward case, making the user believe that forward debugging could not
>> continue.
>>
>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31224
>> ---
>
>Hi! I think this is good to go in, but I would like Markus to chime in
>before pushing, since he mantains the other record subsystem, so for now
>
>Reviewed-By: Guinevere Larsen <blarsen@redhat.com>

OK for btrace.

Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

  reply	other threads:[~2024-08-13  8:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-02 16:43 Alex Chronopoulos
2024-08-12 19:50 ` Guinevere Larsen
2024-08-13  8:52   ` Metzger, Markus T [this message]
2024-08-13 11:55     ` Guinevere Larsen
2024-08-13 18:18       ` Alex Chronopoulos
2024-08-13 18:26         ` Guinevere Larsen
2024-08-23 12:25           ` Alex Chronopoulos
2024-08-26 13:41             ` Guinevere Larsen
2024-08-27 10:17               ` Tom de Vries
2024-08-27 11:07                 ` Guinevere Larsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM8PR11MB5749ED2D6C5FDD284440F999DE862@DM8PR11MB5749.namprd11.prod.outlook.com \
    --to=markus.t.metzger@intel.com \
    --cc=achronop@gmail.com \
    --cc=blarsen@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox