From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CQ3GNx2GzGZdJxUAWB0awg (envelope-from ) for ; Mon, 26 Aug 2024 09:41:49 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WgAnoCjh; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CBE0A1E0D0; Mon, 26 Aug 2024 09:41:49 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A53D91E0AC for ; Mon, 26 Aug 2024 09:41:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 282B3385DDD0 for ; Mon, 26 Aug 2024 13:41:47 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id F1079385DDC7 for ; Mon, 26 Aug 2024 13:41:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F1079385DDC7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F1079385DDC7 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724679680; cv=none; b=M/vdf4NtaV9GIXwmW2BjI94hGbHBzk0syh+eoV4Xvysx+RthQ2yUghQiY8jL8l0sk21MnOvULXVevlbTIaKIlXOP8lQQNCslOE5XzLZv8aiRagIHkqCPLmBK3+EkdVpCkSvZDkap7JcEmVkf6tsE7p/TFpe0XO3VpNYig6I0oc0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724679680; c=relaxed/simple; bh=d1ffgfjtC66xkggWIRSaiEFygc+5S7aoKL9UFqpg410=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=eUn8CPe03iVeFS70cYKEurKYnIzhUmipk46+7vPsPmCxXtlmb2EiJOdQoJgtqClSpBst8qbY7lAY2hib6fmH4I8+P6RRZavC0PhFAkT6aRj2kGmjyy6vHVoDKt9+QW87B6jS7arwimIKSphw2IlsuMwVtDLwDc4A3+YxH48LffA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724679677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=50aEVplLRC+bBDN/BFOvl2elL26EKefGCmJP3a18MtE=; b=WgAnoCjhJ8bz4FQVngbZdRH3XdSJ2lP4pt3rnwNMBCpr1TE1AOL12zQX0JCM06BLzwmCiM 02ed1HAx4nqtO8Fhs9yt/8EKTS07hC8BvqSj5rk1CcZ4UcH8ugWOMnuQiXDxLkLFbTCDtk 1AiwzjPOEctxVlqM3VpiMzIyTMsdzmo= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-zHSsD81zONu3PD7qdAXnTg-1; Mon, 26 Aug 2024 09:41:16 -0400 X-MC-Unique: zHSsD81zONu3PD7qdAXnTg-1 Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-714203541e1so3974364b3a.0 for ; Mon, 26 Aug 2024 06:41:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724679674; x=1725284474; h=in-reply-to:from:content-language:references:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=50aEVplLRC+bBDN/BFOvl2elL26EKefGCmJP3a18MtE=; b=Dd538YSP9t58ejrt/TLfze6hPtE+wd+a5qXGHvjho/sXBpvrg3rLALH62V3v5Ud82x rVHkpx42GstCZScjQdY8mNwRwQ9SKSjocCNdEa9ZSPnLnCpKhduVhO8YNfrx9LIEqDro u6HM0fjjD8WBjUCZ9uQLC2B6eCmzYrL/1x5Ch6LqCI1H4lbizPh78xKzzeER71HA8zFL mjrVGLBbg1kFpC4YJCVINypjC1dAGGS75NDl2/DmQOv7d/5QbgjSSjQmAb4c6ULKaKfm ZSQ6U1qYlfT7cFcXIK2BylyROiS8w1Lh9obKBC9GxM8JUlMhuY3gk7kgrmMxHHvTuOaV iX/A== X-Forwarded-Encrypted: i=1; AJvYcCWN2t11iM4KBZm3YojnWOyDpBIRwHM33w6djn19dTTtBZRIY14wjWFBqvuzbKlzvVl/jbn1/FEGTCUTKg==@sourceware.org X-Gm-Message-State: AOJu0Yx0aE4arqLnge3eCLIjNtW3Byb+mEfZwhVU0B9H1nUJmboQwk8n p07uaRuv0aHquWIxu5UViXStv7Als78+9dOlqwYNKbR/I7653QrPdh0Yl8ZXHja+xwMPlD2y+V0 qHOUzejOrGrurxtPjFEPX9GYYryTFbQtPti3uIIVhPmU3DjkAY+lBnnCJ68u+yUhVE38= X-Received: by 2002:a05:6a00:1301:b0:6f8:e1c0:472f with SMTP id d2e1a72fcca58-714457814c4mr13583480b3a.8.1724679674278; Mon, 26 Aug 2024 06:41:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF66hmF+zSGQJnCNvwjLWXNcg+OL9C0PcBfoRRI0sql+IL135G1nwf000EK3PV2/SsFBORdhg== X-Received: by 2002:a05:6a00:1301:b0:6f8:e1c0:472f with SMTP id d2e1a72fcca58-714457814c4mr13583437b3a.8.1724679673649; Mon, 26 Aug 2024 06:41:13 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1000? ([2804:14d:8084:92c5::1000]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71434316663sm7019689b3a.183.2024.08.26.06.41.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2024 06:41:13 -0700 (PDT) Message-ID: <18f1a5da-5581-4dcc-bdf3-2aaf2b161d31@redhat.com> Date: Mon, 26 Aug 2024 10:41:10 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6] Change message when reaching end of reverse history. To: Alex Chronopoulos , "gdb-patches@sourceware.org" References: <20240802164306.252264-1-achronop@gmail.com> <9388437d-557d-45df-8513-d0a91a8e97a7@redhat.com> <23584087-2048-4904-825a-48b0f9d60ebb@redhat.com> <1d10c73b-0c94-46b5-a1a3-310bb48eed16@redhat.com> From: Guinevere Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="------------b9TzLiT5lYGnqgYRmcYLvGZh" Content-Language: en-US X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This is a multi-part message in MIME format. --------------b9TzLiT5lYGnqgYRmcYLvGZh Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Pushed :) though, I'm very sorry, I messed up some git command and ended up as the author, and only realized after the push. I don't think there's a way to amend it once it's pushed :( -- Cheers, Guinevere Larsen She/Her/Hers On 8/23/24 9:25 AM, Alex Chronopoulos wrote: > Since it takes some time, could you go on and land this one? I will > have coordinated with Tom by the next time it's needed. > > On Tue, Aug 13, 2024 at 9:26 PM Guinevere Larsen > wrote: > > I'm CC-ing Tom Tromey, as he's the one who usually talks about > this in the list. Tom, Could you take care of this? > > -- > Cheers, > Guinevere Larsen > She/Her/Hers > > On 8/13/24 3:18 PM, Alex Chronopoulos wrote: >> Hooray \o/ >> Thank you for the reviews. >> I would like to push myself, how can I get write-after-approval >> rights? >> >> On Tue, Aug 13, 2024 at 2:55 PM Guinevere Larsen >> wrote: >> >> On 8/13/24 5:52 AM, Metzger, Markus T wrote: >> > Hello Alex, >> > >> >>> In a record session, when we move backward, GDB switches >> from normal >> >>> execution to simulation. Moving forward again, the >> emulation continues >> >>> until the end of the reverse history. When the end is >> reached, the >> >>> execution stops, and a warning message is shown. This >> message has been >> >>> modified to indicate that the forward emulation has >> reached the end, but >> >>> the execution can continue as normal, and the recording >> will also continue. >> >>> >> >>> Before this patch, the warning message shown in that case >> was the same as >> >>> in the reverse case. This meant that when the end of >> history was reached in >> >>> either backward or forward emulation, the same message >> was displayed: >> >>> >> >>> "No more reverse-execution history." >> >>> >> >>> This message has changed for these two cases. Backward >> emulation: >> >>> >> >>> "Reached end of recorded history; stopping. >> >>> Backward execution from here not possible." >> >>> >> >>> Forward emulation: >> >>> >> >>> "Reached end of recorded history; stopping. >> >>> Following forward execution will be added to history." >> >>> >> >>> The reason for this change is that the initial message >> was deceiving, for >> >>> the forward case, making the user believe that forward >> debugging could not >> >>> continue. >> >>> >> >>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31224 >> >>> --- >> >> Hi! I think this is good to go in, but I would like Markus >> to chime in >> >> before pushing, since he mantains the other record >> subsystem, so for now >> >> >> >> Reviewed-By: Guinevere Larsen >> > OK for btrace. >> >> Awesome! Alex, feel free to change my tag to: Approved-By: >> Guinevere >> Larsen >> >> Do you already have write after approval rights for the repo? >> If not, do >> you plan to send more patches, so it makes sense to go after >> it? If not, >> I can push this for you :) >> >> -- >> Cheers, >> Guinevere Larsen >> She/Her/Hers >> >> > >> > Markus. >> > Intel Deutschland GmbH >> > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany >> > Tel: +49 89 99 8853-0, www.intel.de >> > Managing Directors: Sean Fennelly, Jeffrey Schneiderman, >> Tiffany Doon Silva >> > Chairperson of the Supervisory Board: Nicole Lau >> > Registered Office: Munich >> > Commercial Register: Amtsgericht Muenchen HRB 186928 >> --------------b9TzLiT5lYGnqgYRmcYLvGZh Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
Pushed :)
though, I'm very sorry, I messed up some git command and ended up as the author, and only realized after the push. I don't think there's a way to amend it once it's pushed :(
-- 
Cheers,
Guinevere Larsen
She/Her/Hers
On 8/23/24 9:25 AM, Alex Chronopoulos wrote:
Since it takes some time, could you go on and land this one? I will have coordinated with Tom by the next time it's needed.

On Tue, Aug 13, 2024 at 9:26 PM Guinevere Larsen <blarsen@redhat.com> wrote:
I'm CC-ing Tom Tromey, as he's the one who usually talks about this in the list. Tom, Could you take care of this?
-- 
Cheers,
Guinevere Larsen
She/Her/Hers
On 8/13/24 3:18 PM, Alex Chronopoulos wrote:
Hooray \o/
Thank you for the reviews.
I would like to push myself, how can I get write-after-approval rights?

On Tue, Aug 13, 2024 at 2:55 PM Guinevere Larsen <blarsen@redhat.com> wrote:
On 8/13/24 5:52 AM, Metzger, Markus T wrote:
> Hello Alex,
>
>>> In a record session, when we move backward, GDB switches from normal
>>> execution to simulation. Moving forward again, the emulation continues
>>> until the end of the reverse history. When the end is reached, the
>>> execution stops, and a warning message is shown. This message has been
>>> modified to indicate that the forward emulation has reached the end, but
>>> the execution can continue as normal, and the recording will also continue.
>>>
>>> Before this patch, the warning message shown in that case was the same as
>>> in the reverse case. This meant that when the end of history was reached in
>>> either backward or forward emulation, the same message was displayed:
>>>
>>> "No more reverse-execution history."
>>>
>>> This message has changed for these two cases. Backward emulation:
>>>
>>> "Reached end of recorded history; stopping.
>>> Backward execution from here not possible."
>>>
>>> Forward emulation:
>>>
>>> "Reached end of recorded history; stopping.
>>> Following forward execution will be added to history."
>>>
>>> The reason for this change is that the initial message was deceiving, for
>>> the forward case, making the user believe that forward debugging could not
>>> continue.
>>>
>>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31224
>>> ---
>> Hi! I think this is good to go in, but I would like Markus to chime in
>> before pushing, since he mantains the other record subsystem, so for now
>>
>> Reviewed-By: Guinevere Larsen <blarsen@redhat.com>
> OK for btrace.

Awesome! Alex, feel free to change my tag to: Approved-By: Guinevere
Larsen <blarsen@redhat.com>

Do you already have write after approval rights for the repo? If not, do
you plan to send more patches, so it makes sense to go after it? If not,
I can push this for you :)

--
Cheers,
Guinevere Larsen
She/Her/Hers

>
> Markus.
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de
> Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928

--------------b9TzLiT5lYGnqgYRmcYLvGZh--