Re: [PATCH 1/2] [gdb] Make regformats/regdat.sh shellcheck-clean

[Simon Marchi <simark@simark.ca>]

On 2026-08-28 08:04, Tom de Vries wrote:
> Make regformats/regdat.sh shellcheck-clean:
> - use read -r
> - use $()
> - ignore intentional word-splitting
> - add missing quotes
> - use $(())
> 
> Handle a shellcheck error in this:
> ...
>   if eval test \"\${${r}}\" = \"\ \"
> ...
> by simplifying to:
> ...
>   eval "rvalue=\$$r"
>   if test "${rvalue:-}" = " "
> ...
> 
> Note that shellcheck can't detect that rvalue is assigned to, so we use
> '${parameter:-word}' to use default value "", to silence a SC2154 [1].
> 
> Also, handle a shellcheck error in this:
> ...
>   eval ${r}=""
> ...
> by simplifying to:
> ...
>   eval "$r=''"
> ...
> 
> Tested on x86_64-linux using:
> ...
> $ for f in $(find gdb/regformats -name "*.dat"); do \
>       sh gdb/regformats/regdat.sh \
>           $f \
> 	  gdbsupport/osabi.def \
> 	  $(echo $f | sed 's%/%-%g'); \
>   done
> ...
> and comparing the generated files with and without this patch.

LGTM, thanks.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Random thought: I wonder why we don't check in the result of running
regdat.sh in the repo, like we do for gdbarch-gen.{c,h},
target-delegates-gen.c, and the features directory.  The output doesn't
change from build to build, and that would make it easy to see that your
patch did not produce any change in the output files.

Simon