Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] [gdb] Make regformats/regdat.sh shellcheck-clean
Date: Fri, 28 Aug 2026 16:40:35 +0200	[thread overview]
Message-ID: <0aca0232-cda3-4c6e-8fd8-dc53328bc303@suse.de> (raw)
In-Reply-To: <17c2d558-7cd7-4906-8fa2-b4f21f56f52a@simark.ca>

On 8/28/26 2:43 PM, Simon Marchi wrote:
> Random thought: I wonder why we don't check in the result of running
> regdat.sh in the repo, like we do for gdbarch-gen.{c,h},
> target-delegates-gen.c, and the features directory.  The output doesn't
> change from build to build, and that would make it easy to see that your
> patch did not produce any change in the output files.

Good question, hadn't thought about it.

I suppose not checking in an intermediate result means you never use 
something stale, so I guess it comes down to how you want to prevent that.

Thanks,
- Tom


  reply	other threads:[~2026-08-28 14:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28 12:04 [PATCH 0/2] [gdb] Two regformats/regdat.sh fixes Tom de Vries
2026-08-28 12:04 ` [PATCH 1/2] [gdb] Make regformats/regdat.sh shellcheck-clean Tom de Vries
2026-08-28 12:43   ` Simon Marchi
2026-08-28 14:40     ` Tom de Vries [this message]
2026-08-28 13:34   ` Andreas Schwab
2026-08-28 14:04     ` Tom de Vries
2026-08-28 12:04 ` [PATCH 2/2] [gdb] Fix unbound variable in regformats/regdat.sh Tom de Vries
2026-08-28 12:46   ` Simon Marchi
2026-08-28 14:19     ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0aca0232-cda3-4c6e-8fd8-dc53328bc303@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox