Re: [PATCH 2/2] [gdb] Fix unbound variable in regformats/regdat.sh

[Tom de Vries <tdevries@suse.de>]

On 8/28/26 2:46 PM, Simon Marchi wrote:
> Unrelated comment: I'd like if we could standardize on
> 
>    if ...; then
>    for ... in ...; do
>    while ...; do
> 
> instead of
> 
>    if ...
>    then
> 
>    for ... in ...
>    do
> 
>    while ...
>    do
> 
> I think it's more common, easier to read and takes less unnecessary
> lines.

Agreed.  I almost started doing this manually, but suddenly remembered 
that pretty-printers exist.

I've used shfmt ( 
https://sourceware.org/pipermail/gdb-patches/2026-August/229822.html ).

I also tried out beautysh (which would have been easy to integrate into 
pre-commit, because it's python), but it doesn't seem to fix this style.

I also tried out bash --pretty-print, but it has run-away indentation 
and doesn't seem to support customization.

Thanks,
- Tom