From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ef/CGgeZkWq6vwsAWB0awg (envelope-from ) for ; Fri, 28 Aug 2026 10:19:51 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nln2RPVB; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=c+bA8N1E; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=hec12VKU; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=0S8WxnIc; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 697AD1E166; Fri, 28 Aug 2026 10:19:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8C2BB1E033 for ; Fri, 28 Aug 2026 10:19:50 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B951F4BA799D for ; Fri, 28 Aug 2026 14:19:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B951F4BA799D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nln2RPVB; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=c+bA8N1E; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=hec12VKU; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=0S8WxnIc Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id A0E0C4BA2E1F for ; Fri, 28 Aug 2026 14:19:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A0E0C4BA2E1F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A0E0C4BA2E1F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787926765; cv=none; b=Q06GDSvkrTwOxx28fGKvnRuaZ83i+ZWvWbDfZ7Y/1EGNycB7KucQlHFDZFPW+Pe6+8LnDW6mv9Cnck4moYrFNivp6PhrV7mAWBuXYnB9i116UY4UsfHjcwZsTNANBn17xOqGeHvyRhX3OVCsaLDVABlmbcRlEPxt7LvtufW4rK8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787926765; c=relaxed/simple; bh=d1Mo3+pim6FnrxvAft7QVSU5ZjgzpTcgDTVRMbtX7gc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=SseaJRbMkDx8/figruvG7sE+pAyuNRYSA1N5gQTO+ppGE6gX3lqf/o98q/WscY6wt6L065raFzW/XHh8HZU6gGk1idaKnpRmE4YY+faUqIKoF0htsGTM6eWdor/elLQMmyHgnTDdxePWChFlHntMHQ7SUwZcqd8zpCMm3BzqWH0= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nln2RPVB; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=c+bA8N1E; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=hec12VKU; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=0S8WxnIc DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A0E0C4BA2E1F Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4660422399; Fri, 28 Aug 2026 14:19:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787926760; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8W9OQZKgPcPn3RfcwK+qSxIoAnw5lnF7Hf5Pvx0V/XI=; b=nln2RPVBjokXjcg3w9ea2SoU+3AhmxrQPMfdgIFhZ067Sg/l6V06rLnZNs8FEla8rv43br 59AjIjkv6a9ofyPmfyIpCi5QoEY3kbGBFTydNeTiQy6MK7Oi9wQ7jwJtOP+Fy6S8Bnwuzr ADDcaS8Z+QN0bl6lQ/QtrO9MUhG8EUc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787926760; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8W9OQZKgPcPn3RfcwK+qSxIoAnw5lnF7Hf5Pvx0V/XI=; b=c+bA8N1EtK4SiW5GFq33dmMZWBj3IqqOFk+FUc9urnfSfzhlSDmAzQvLZTzbQSexCtI2hJ P4DY7DwnhVCuB/Aw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=hec12VKU; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0S8WxnIc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787926756; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8W9OQZKgPcPn3RfcwK+qSxIoAnw5lnF7Hf5Pvx0V/XI=; b=hec12VKUh8q9poXeG4qIcrXq7hPQIdPrerKL4zXlMTXb7u/T5hEBYnR2+UCmmO+PA9HpHl TC6YHA79BhnuvbZgABTLH8clIqKMLqtmsyU8GB4EhnpLMZ7NXfrOaLC7Av6fRmuJEB4C2W /EUYaPVlA27JrHoZ7yduy9osjy3sXiA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787926756; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8W9OQZKgPcPn3RfcwK+qSxIoAnw5lnF7Hf5Pvx0V/XI=; b=0S8WxnIcEYfV1RvnmptBbcDjv4FomNIfAeDTo8djFokISkuHDZVh983B3KeQNjOGXAMHMV JPyYaFBqn/f/DWCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 145A113515; Fri, 28 Aug 2026 14:19:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id JsgJA+SYkWr3IgAAD6G6ig (envelope-from ); Fri, 28 Aug 2026 14:19:16 +0000 Message-ID: <057c1ec2-e37b-4ea5-ac2e-ee0f9ff234e2@suse.de> Date: Fri, 28 Aug 2026 16:19:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] [gdb] Fix unbound variable in regformats/regdat.sh To: Simon Marchi , gdb-patches@sourceware.org References: <20260828120439.3857602-1-tdevries@suse.de> <20260828120439.3857602-3-tdevries@suse.de> <987c9664-c0ed-4052-be6c-cb80eec17dff@simark.ca> Content-Language: en-US From: Tom de Vries In-Reply-To: <987c9664-c0ed-4052-be6c-cb80eec17dff@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 4660422399 X-Spamd-Result: default: False [-5.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; DWL_DNSWL_LOW(-1.00)[suse.de:dkim]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,sourceware.org:url,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/28/26 2:46 PM, Simon Marchi wrote: > Unrelated comment: I'd like if we could standardize on > > if ...; then > for ... in ...; do > while ...; do > > instead of > > if ... > then > > for ... in ... > do > > while ... > do > > I think it's more common, easier to read and takes less unnecessary > lines. Agreed. I almost started doing this manually, but suddenly remembered that pretty-printers exist. I've used shfmt ( https://sourceware.org/pipermail/gdb-patches/2026-August/229822.html ). I also tried out beautysh (which would have been easy to integrate into pre-commit, because it's python), but it doesn't seem to fix this style. I also tried out bash --pretty-print, but it has run-away indentation and doesn't seem to support customization. Thanks, - Tom