From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8pQnM4yCkWrLWwsAWB0awg (envelope-from ) for ; Fri, 28 Aug 2026 08:43:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1787921036; bh=JHC85ERw8wM3g+7d6JLkSMykXeU9HhB4N5CRBSnoPNI=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MhkoLrC1NPE9YvU/ctRKjm/wLAgQte4OvVlbWXIJCJ0fOtA2/vOzTviKD2/MR5wlw tPPlQseI6pu9WK79gZAJQy4EIGO/FRn8NRl0UndV6PbStgq4ABGnkuOPZSFiSU90/D n350x+8f2W1NIOPJBvEkK4q2AfH9ml7beVAGF7XQ= Received: by simark.ca (Postfix, from userid 112) id ABCD71E166; Fri, 28 Aug 2026 08:43:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=BEA8TOiz; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EF1451E033 for ; Fri, 28 Aug 2026 08:43:55 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 77C964BA23CB for ; Fri, 28 Aug 2026 12:43:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 77C964BA23CB Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=BEA8TOiz Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id CA33E4BA2E28 for ; Fri, 28 Aug 2026 12:43:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CA33E4BA2E28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CA33E4BA2E28 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787921012; cv=none; b=RLoMXJC0MnvysGgNWsm3lMiv56AGuY2vn+fysPTEitcQ7WC1JcOy2ARBEedAIwCP2M1hQeYk6GMnrYRGlLQZNXkmFGuriDCWfw2tmWzfJXyYP/eIpppuFAFhM8/rMkIdKBpXXHgYvEnf7JFBQAot3KCS3W+1HdNQaISvnU9uCNg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787921012; c=relaxed/simple; bh=JHC85ERw8wM3g+7d6JLkSMykXeU9HhB4N5CRBSnoPNI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=HSfka6J8G03UPhlJZ4VlO0XJ95YpiclYEJbE5dqDyGCr0N94j/AEcvkCKUrXd+Dj9Xfhr8GPPCjuN7F3X11qejnstCpDoDFjhRY5wtXNc/JDYye6CrHUl9zAQUymf0fpiRgxsEm3tQvLI/6Xml7sFZeiNY7fFGBdE6q4LsGwhXo= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=BEA8TOiz DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CA33E4BA2E28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1787921009; bh=JHC85ERw8wM3g+7d6JLkSMykXeU9HhB4N5CRBSnoPNI=; h=Date:Subject:To:References:From:In-Reply-To:From; b=BEA8TOiz/T7GgdvhhXFFfA3XT2Wo7Dw9LgzI27Xa689nPTDZ5gIc9+Nal/W3gIknq 5yScEYkq0sAbXD0LYnO7OA5hBNoUCk1iUTgPCAnrosmrhf0rKevzAseMZjA8Y56XAT hYsQ8cvA2V2/4P7qWOTAB35SuzYJqQa2tGDmogmU= Received: by simark.ca (Postfix) id 761C11E033; Fri, 28 Aug 2026 08:43:29 -0400 (EDT) Message-ID: <17c2d558-7cd7-4906-8fa2-b4f21f56f52a@simark.ca> Date: Fri, 28 Aug 2026 08:43:28 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] [gdb] Make regformats/regdat.sh shellcheck-clean To: Tom de Vries , gdb-patches@sourceware.org References: <20260828120439.3857602-1-tdevries@suse.de> <20260828120439.3857602-2-tdevries@suse.de> Content-Language: en-US From: Simon Marchi In-Reply-To: <20260828120439.3857602-2-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-08-28 08:04, Tom de Vries wrote: > Make regformats/regdat.sh shellcheck-clean: > - use read -r > - use $() > - ignore intentional word-splitting > - add missing quotes > - use $(()) > > Handle a shellcheck error in this: > ... > if eval test \"\${${r}}\" = \"\ \" > ... > by simplifying to: > ... > eval "rvalue=\$$r" > if test "${rvalue:-}" = " " > ... > > Note that shellcheck can't detect that rvalue is assigned to, so we use > '${parameter:-word}' to use default value "", to silence a SC2154 [1]. > > Also, handle a shellcheck error in this: > ... > eval ${r}="" > ... > by simplifying to: > ... > eval "$r=''" > ... > > Tested on x86_64-linux using: > ... > $ for f in $(find gdb/regformats -name "*.dat"); do \ > sh gdb/regformats/regdat.sh \ > $f \ > gdbsupport/osabi.def \ > $(echo $f | sed 's%/%-%g'); \ > done > ... > and comparing the generated files with and without this patch. LGTM, thanks. Approved-By: Simon Marchi Random thought: I wonder why we don't check in the result of running regdat.sh in the repo, like we do for gdbarch-gen.{c,h}, target-delegates-gen.c, and the features directory. The output doesn't change from build to build, and that would make it easy to see that your patch did not produce any change in the output files. Simon