* [patch] remove pointless call.
@ 2003-05-12 18:19 Kris Warkentin
2003-05-12 18:57 ` Andrew Cagney
0 siblings, 1 reply; 4+ messages in thread
From: Kris Warkentin @ 2003-05-12 18:19 UTC (permalink / raw)
To: Gdb-Patches@Sources.Redhat.Com
Okay to apply? The TARGET_FIND_AND_OPEN_SOLIB removes the need for this
call.
cheers,
Kris
Changelog:
* nto-tdep.c (fetch_core_registers): Remove redundant call to
nto_init_solib_absolute_prefix.
RCS file: /cvs/src/src/gdb/nto-tdep.c,v
retrieving revision 1.3
diff -c -r1.3 nto-tdep.c
*** nto-tdep.c 6 May 2003 17:13:40 -0000 1.3
--- nto-tdep.c 12 May 2003 17:43:10 -0000
***************
*** 270,277 ****
{
nto_regset_t regset;
- nto_init_solib_absolute_prefix ();
-
if (which == NTO_REG_GENERAL)
{
memcpy ((char *) ®set, core_reg_sect,
--- 270,275 ----
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] remove pointless call.
2003-05-12 18:19 [patch] remove pointless call Kris Warkentin
@ 2003-05-12 18:57 ` Andrew Cagney
2003-05-12 19:16 ` Kris Warkentin
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Cagney @ 2003-05-12 18:57 UTC (permalink / raw)
To: Kris Warkentin; +Cc: Gdb-Patches@Sources.Redhat.Com
> Okay to apply? The TARGET_FIND_AND_OPEN_SOLIB removes the need for this
> call.
Yes (obvious?).
> Changelog:
>
> * nto-tdep.c (fetch_core_registers): Remove redundant call to
> nto_init_solib_absolute_prefix.
>
> RCS file: /cvs/src/src/gdb/nto-tdep.c,v
> retrieving revision 1.3
> diff -c -r1.3 nto-tdep.c
> *** nto-tdep.c 6 May 2003 17:13:40 -0000 1.3
> --- nto-tdep.c 12 May 2003 17:43:10 -0000
> ***************
> *** 270,277 ****
> {
> nto_regset_t regset;
>
> - nto_init_solib_absolute_prefix ();
> -
> if (which == NTO_REG_GENERAL)
> {
> memcpy ((char *) ®set, core_reg_sect,
> --- 270,275 ----
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] remove pointless call.
2003-05-12 18:57 ` Andrew Cagney
@ 2003-05-12 19:16 ` Kris Warkentin
2003-05-12 19:24 ` Andrew Cagney
0 siblings, 1 reply; 4+ messages in thread
From: Kris Warkentin @ 2003-05-12 19:16 UTC (permalink / raw)
To: Andrew Cagney; +Cc: Gdb-Patches@Sources.Redhat.Com
> > Okay to apply? The TARGET_FIND_AND_OPEN_SOLIB removes the need for this
> > call.
>
> Yes (obvious?).
Is it in general okay to just post and apply patches to my own files if
they're obvious? Do I need to be put down as a target specific maintainer
or some such?
cheers,
Kris
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] remove pointless call.
2003-05-12 19:16 ` Kris Warkentin
@ 2003-05-12 19:24 ` Andrew Cagney
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Cagney @ 2003-05-12 19:24 UTC (permalink / raw)
To: Kris Warkentin; +Cc: Gdb-Patches@Sources.Redhat.Com
>> > Okay to apply? The TARGET_FIND_AND_OPEN_SOLIB removes the need for this
>> > call.
>
>>
>> Yes (obvious?).
>
>
> Is it in general okay to just post and apply patches to my own files if
> they're obvious?
Yes. Whats the worst you could do, break it? :-)
> Do I need to be put down as a target specific maintainer
> or some such?
I'll go and ask the global maintainers.
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-05-12 19:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-12 18:19 [patch] remove pointless call Kris Warkentin
2003-05-12 18:57 ` Andrew Cagney
2003-05-12 19:16 ` Kris Warkentin
2003-05-12 19:24 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox