From: Elena Zannoni <ezannoni@redhat.com>
To: mec.gnu@mindspring.com (Michael Elizabeth Chastain)
Cc: fnf@ninemoons.com, ac131313@redhat.com, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Outwit compiler dead code elimination in break.exp test
Date: Mon, 29 Dec 2003 20:20:00 -0000 [thread overview]
Message-ID: <16360.1865.40486.957625@localhost.redhat.com> (raw)
In-Reply-To: <20031209065241.178254B412@berman.michael-chastain.com>
Michael Elizabeth Chastain writes:
> It works for me. My before-and-after tests came out clean again; all
> the copyright dates look good; and the comment about the separate file
> is exactly what I wanted.
>
> Endorsed for approval.
>
> (I'm trying to come up with some word that means "I don't have approval
> authority but I'll vouch for this patch" ... "endorsed"? "recommended"?)
>
I can rubberstamp it. However Fred could self approve it too.
elena
> Michael C
>
> ===
>
> 2003-12-07 Fred Fish <fnf@redhat.com>
>
> * gdb.base/break.c (marker1, marker2, marker3, marker4): Move
> functions to break1.c and leave prototypes behind. Add more
> "set breakpoint NN here" comments.
> * gdb.base/break1.c: New file.
>
> * gdb.base/break.exp: Handle compiling test case from multiple
> source files and change source file references as needed.
> * gdb.base/completion.exp: Ditto.
> * gdb.base/condbreak.exp: Ditto.
> * gdb.base/define.exp: Ditto.
> * gdb.base/ena-dis-br.exp: Ditto.
> * gdb.base/info-proc.exp: Ditto.
> * gdb.base/maint.exp: Ditto.
> * gdb.base/until.exp: Ditto.
>
> * gdb.base/condbreak.exp: Use bp_locationNN variables instead of
> hardcoded line numbers.
> * gdb.base/define.exp: Ditto.
> * gdb.base/ena-dis-br.exp: Ditto.
> * gdb.base/maint.exp: Ditto.
> * gdb.base/until.exp: Ditto.
>
> * gdb.base/completion.exp: Use "break1" for completion tests since
> "break" is no longer a unique prefix.
next prev parent reply other threads:[~2003-12-29 20:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-09 6:52 Michael Elizabeth Chastain
2003-12-29 20:20 ` Elena Zannoni [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-12-08 23:49 [PATCH] Outwit compiler dead code elimination in break.exp test (revised patch) Andrew Cagney
2003-12-09 5:06 ` [PATCH] Outwit compiler dead code elimination in break.exp test Fred Fish
2003-12-01 16:55 Michael Elizabeth Chastain
2003-11-29 23:05 Fred Fish
2003-11-30 1:04 ` Fred Fish
2003-11-30 1:07 ` Daniel Jacobowitz
2003-11-30 1:26 ` Fred Fish
2003-12-01 0:46 ` Fred Fish
2003-12-01 14:58 ` Elena Zannoni
2003-12-01 15:30 ` Fred Fish
2003-12-01 15:46 ` Elena Zannoni
2003-12-01 16:39 ` Fred Fish
2003-12-01 14:23 ` Elena Zannoni
2003-12-01 14:44 ` Daniel Jacobowitz
2003-12-01 17:52 ` Andrew Cagney
2003-12-01 18:10 ` Fred Fish
2003-12-09 1:02 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16360.1865.40486.957625@localhost.redhat.com \
--to=ezannoni@redhat.com \
--cc=ac131313@redhat.com \
--cc=fnf@ninemoons.com \
--cc=gdb-patches@sources.redhat.com \
--cc=mec.gnu@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox