Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: mec.gnu@mindspring.com (Michael Elizabeth Chastain)
To: fnf@ninemoons.com
Cc: ezannoni@redhat.com, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Outwit compiler dead code elimination in break.exp test
Date: Mon, 01 Dec 2003 16:55:00 -0000	[thread overview]
Message-ID: <20031201165515.7C2524B365@berman.michael-chastain.com> (raw)

ff> The messages will now be something like:
ff>   PASS: gdb.base/break.exp: set to-be-silent break bp_location1
ff> instead of:
ff>   PASS: gdb.base/break.exp: set to-be-silent break 83

Mmmmm, a test suite discussion.  Can I throw two cents in?  :)

Either message looks fine to me.  It's important that the message
be unique within the test script, and either message would be unique
within the test script.  And it's important that the message not change
from run to run, and "break 83" does not change from run to run
unless someone actually changes the test script.

So "break 83" wasn't a big problem but "break bp_location1" appeals
more to me esthetically.

Michael C


             reply	other threads:[~2003-12-01 16:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-01 16:55 Michael Elizabeth Chastain [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-12-09  6:52 Michael Elizabeth Chastain
2003-12-29 20:20 ` Elena Zannoni
2003-12-08 23:49 [PATCH] Outwit compiler dead code elimination in break.exp test (revised patch) Andrew Cagney
2003-12-09  5:06 ` [PATCH] Outwit compiler dead code elimination in break.exp test Fred Fish
2003-11-29 23:05 Fred Fish
2003-11-30  1:04 ` Fred Fish
2003-11-30  1:07   ` Daniel Jacobowitz
2003-11-30  1:26     ` Fred Fish
2003-12-01  0:46     ` Fred Fish
2003-12-01 14:58       ` Elena Zannoni
2003-12-01 15:30         ` Fred Fish
2003-12-01 15:46           ` Elena Zannoni
2003-12-01 16:39             ` Fred Fish
2003-12-01 14:23     ` Elena Zannoni
2003-12-01 14:44       ` Daniel Jacobowitz
2003-12-01 17:52 ` Andrew Cagney
2003-12-01 18:10   ` Fred Fish
2003-12-09  1:02     ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031201165515.7C2524B365@berman.michael-chastain.com \
    --to=mec.gnu@mindspring.com \
    --cc=ezannoni@redhat.com \
    --cc=fnf@ninemoons.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox