From: Elena Zannoni <ezannoni@redhat.com>
To: fnf@ninemoons.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Outwit compiler dead code elimination in break.exp test
Date: Mon, 01 Dec 2003 15:46:00 -0000 [thread overview]
Message-ID: <16331.25172.341946.691722@localhost.redhat.com> (raw)
In-Reply-To: <200312010829.17695.fnf@ninemoons.com>
Fred Fish writes:
> > > Emit bp_locationNN markers in pass
> > > and fail messages instead of line numbers.
> >
> > Why this? The line numbers were not really hardcoded.
>
> Generally I believe you should not emit values in the pass/fail
> messages that are subject to change, such as addresses, line numbers,
> etc. This way you can diff successive summary files without seeing
> spurious differences.
>
> However I can revert that part of the patch if that is an issue.
If the pass/fil messages are unique within the .exp files, then ok.
>
> -Fred
>
next prev parent reply other threads:[~2003-12-01 15:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-29 23:05 Fred Fish
2003-11-30 1:04 ` Fred Fish
2003-11-30 1:07 ` Daniel Jacobowitz
2003-11-30 1:26 ` Fred Fish
2003-12-01 0:46 ` Fred Fish
2003-12-01 14:58 ` Elena Zannoni
2003-12-01 15:30 ` Fred Fish
2003-12-01 15:46 ` Elena Zannoni [this message]
2003-12-01 16:39 ` Fred Fish
2003-12-01 14:23 ` Elena Zannoni
2003-12-01 14:44 ` Daniel Jacobowitz
2003-12-01 17:52 ` Andrew Cagney
2003-12-01 18:10 ` Fred Fish
2003-12-09 1:02 ` Michael Snyder
2003-12-07 21:21 ` [PATCH] Outwit compiler dead code elimination in break.exp test (revised patch) Fred Fish
2003-12-08 0:31 ` Andrew Cagney
2003-12-01 16:55 [PATCH] Outwit compiler dead code elimination in break.exp test Michael Elizabeth Chastain
2003-12-08 23:49 [PATCH] Outwit compiler dead code elimination in break.exp test (revised patch) Andrew Cagney
2003-12-09 5:06 ` [PATCH] Outwit compiler dead code elimination in break.exp test Fred Fish
2003-12-09 6:52 Michael Elizabeth Chastain
2003-12-29 20:20 ` Elena Zannoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16331.25172.341946.691722@localhost.redhat.com \
--to=ezannoni@redhat.com \
--cc=fnf@ninemoons.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox