From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26991 invoked by alias); 29 Dec 2003 20:20:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26977 invoked from network); 29 Dec 2003 20:20:29 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 29 Dec 2003 20:20:29 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id 1F6E21A42DE; Tue, 23 Dec 2003 04:13:45 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16360.1865.40486.957625@localhost.redhat.com> Date: Mon, 29 Dec 2003 20:20:00 -0000 To: mec.gnu@mindspring.com (Michael Elizabeth Chastain) Cc: fnf@ninemoons.com, ac131313@redhat.com, gdb-patches@sources.redhat.com Subject: Re: [PATCH] Outwit compiler dead code elimination in break.exp test In-Reply-To: <20031209065241.178254B412@berman.michael-chastain.com> References: <20031209065241.178254B412@berman.michael-chastain.com> X-SW-Source: 2003-12/txt/msg00511.txt.bz2 Michael Elizabeth Chastain writes: > It works for me. My before-and-after tests came out clean again; all > the copyright dates look good; and the comment about the separate file > is exactly what I wanted. > > Endorsed for approval. > > (I'm trying to come up with some word that means "I don't have approval > authority but I'll vouch for this patch" ... "endorsed"? "recommended"?) > I can rubberstamp it. However Fred could self approve it too. elena > Michael C > > === > > 2003-12-07 Fred Fish > > * gdb.base/break.c (marker1, marker2, marker3, marker4): Move > functions to break1.c and leave prototypes behind. Add more > "set breakpoint NN here" comments. > * gdb.base/break1.c: New file. > > * gdb.base/break.exp: Handle compiling test case from multiple > source files and change source file references as needed. > * gdb.base/completion.exp: Ditto. > * gdb.base/condbreak.exp: Ditto. > * gdb.base/define.exp: Ditto. > * gdb.base/ena-dis-br.exp: Ditto. > * gdb.base/info-proc.exp: Ditto. > * gdb.base/maint.exp: Ditto. > * gdb.base/until.exp: Ditto. > > * gdb.base/condbreak.exp: Use bp_locationNN variables instead of > hardcoded line numbers. > * gdb.base/define.exp: Ditto. > * gdb.base/ena-dis-br.exp: Ditto. > * gdb.base/maint.exp: Ditto. > * gdb.base/until.exp: Ditto. > > * gdb.base/completion.exp: Use "break1" for completion tests since > "break" is no longer a unique prefix.