Re: Re: [committed] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)

Re: Re: [committed] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)

[KARTHIKVENKATESH BHAT]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=windows-1252, Size: 1358 bytes --]

Thanks. I have added PR number to Changelog as mentioned.

------- Original Message -------
Sender : Yao Qi<yao@codesourcery.com>
Date : Sep 26, 2012 22:45 (GMT+09:00)
Title : Re: [committed] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)

On 09/26/2012 08:23 PM, KARTHIKVENKATESH BHAT wrote:
> Thanks for the review. Committed after formatting.

The changelog entry is too long, usually it should not exceed 70
characters, and there is a trailing space.  I fixed it in the
patch below.

Your patch fixes a PR, so you should add the PR number into your
changelog entry, so that bugzilla can link this commit to the PR, like
this,


2012-09-26  Karthik Bhat  

PR breakpoints/14419
* arm-tdep.c (arm_skip_prologue): XXXX
-- 
Yao

Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.14700
diff -u -r1.14700 ChangeLog
--- ChangeLog 26 Sep 2012 12:14:30 -0000 1.14700
+++ ChangeLog 26 Sep 2012 13:36:17 -0000
@@ -1,6 +1,7 @@
2012-09-26  Karthik Bhat  

- * arm-tdep.c (arm_skip_prologue): Extending producer check to support LLVM compiler. 
+ * arm-tdep.c (arm_skip_prologue): Extending producer check to
+ support LLVM compiler.

2012-09-26  Siddhesh Poyarekar  \x16º&Öéj×!zÊÞ¶êç÷:ÞX¬µªÜ†\a[¥«\…ë

Re: [committed] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)

[Yao Qi]

On 09/26/2012 10:19 PM, KARTHIKVENKATESH BHAT wrote:
> Thanks. I have added PR number to Changelog as mentioned.

Sorry, the PR number is added in a wrong way.  The blank line is missing 
between your name and PR number.

2012-09-26  Karthik Bhat  <kv.bhat@samsung.com>
//<-- here
	PR breakpoints/14419
	* arm-tdep.c (arm_skip_prologue): Extending producer check to
	support LLVM compiler.

-- 
Yao