Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: KARTHIKVENKATESH BHAT <kv.bhat@samsung.com>
To: Yao Qi <yao@codesourcery.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: Re: [committed] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)
Date: Wed, 26 Sep 2012 14:19:00 -0000	[thread overview]
Message-ID: <15949512.300751348669143606.JavaMail.weblogic@epml01> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=windows-1252, Size: 1358 bytes --]

Thanks. I have added PR number to Changelog as mentioned.

------- Original Message -------
Sender : Yao Qi<yao@codesourcery.com>
Date : Sep 26, 2012 22:45 (GMT+09:00)
Title : Re: [committed] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)

On 09/26/2012 08:23 PM, KARTHIKVENKATESH BHAT wrote:
> Thanks for the review. Committed after formatting.

The changelog entry is too long, usually it should not exceed 70
characters, and there is a trailing space.  I fixed it in the
patch below.

Your patch fixes a PR, so you should add the PR number into your
changelog entry, so that bugzilla can link this commit to the PR, like
this,


2012-09-26  Karthik Bhat  

PR breakpoints/14419
* arm-tdep.c (arm_skip_prologue): XXXX
-- 
Yao

Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.14700
diff -u -r1.14700 ChangeLog
--- ChangeLog 26 Sep 2012 12:14:30 -0000 1.14700
+++ ChangeLog 26 Sep 2012 13:36:17 -0000
@@ -1,6 +1,7 @@
2012-09-26  Karthik Bhat  

- * arm-tdep.c (arm_skip_prologue): Extending producer check to support LLVM compiler. 
+ * arm-tdep.c (arm_skip_prologue): Extending producer check to
+ support LLVM compiler.

2012-09-26  Siddhesh Poyarekar  \x16º&Öéj×!zÊÞ¶êç÷:ÞX¬µªÜ†\a[¥«\…ë

             reply	other threads:[~2012-09-26 14:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-26 14:19 KARTHIKVENKATESH BHAT [this message]
2012-09-26 14:38 ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15949512.300751348669143606.JavaMail.weblogic@epml01 \
    --to=kv.bhat@samsung.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox