From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13726 invoked by alias); 26 Sep 2012 14:19:21 -0000 Received: (qmail 13711 invoked by uid 22791); 26 Sep 2012 14:19:19 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,GENERIC_IXHASH,KHOP_RCVD_UNTRUST,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mailout2.samsung.com (HELO mailout2.samsung.com) (203.254.224.25) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Sep 2012 14:19:06 +0000 Received: from epcpsbge4.samsung.com (epcpsbge4 [203.254.230.14]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MAY007ZPNRM8110@mailout2.samsung.com> for gdb-patches@sourceware.org; Wed, 26 Sep 2012 23:19:04 +0900 (KST) Received: from epcpsbge4.samsung.com ( [172.20.52.122]) by epcpsbge4.samsung.com (EPCPMTA) with SMTP id 81.62.03831.8DE03605; Wed, 26 Sep 2012 23:19:04 +0900 (KST) Received: from epextmailer03 ( [203.254.219.153]) by epcpsbge4.samsung.com (EPCPMTA) with SMTP id 61.62.03831.8DE03605; Wed, 26 Sep 2012 23:19:04 +0900 (KST) Date: Wed, 26 Sep 2012 14:19:00 -0000 From: KARTHIKVENKATESH BHAT Subject: Re: Re: [committed] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419) To: Yao Qi Cc: "gdb-patches@sourceware.org" Reply-to: kv.bhat@samsung.com MIME-version: 1.0 X-MTR: 20120926141633640@kv.bhat Msgkey: 20120926141633640@kv.bhat X-EPLocale: en_US.windows-1252 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-EPTrCode: X-EPTrName: X-MLAttribute: X-RootMTR: 20120926141633640@kv.bhat X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N Content-transfer-encoding: base64 Content-type: text/plain; charset=windows-1252 MIME-version: 1.0 Message-id: <15949512.300751348669143606.JavaMail.weblogic@epml01> DLP-Filter: Pass X-CFilter-Loop: Reflected Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00585.txt.bz2 VGhhbmtzLiBJIGhhdmUgYWRkZWQgUFIgbnVtYmVyIHRvIENoYW5nZWxvZyBh cyBtZW50aW9uZWQuDQoNCi0tLS0tLS0gT3JpZ2luYWwgTWVzc2FnZSAtLS0t LS0tDQpTZW5kZXIgOiBZYW8gUWk8eWFvQGNvZGVzb3VyY2VyeS5jb20+DQpE YXRlIDogU2VwIDI2LCAyMDEyIDIyOjQ1IChHTVQrMDk6MDApDQpUaXRsZSA6 IFJlOiBbY29tbWl0dGVkXSBQcm9sb2d1ZSBub3Qgc2V0IHByb3Blcmx5IGZv ciBiaW5hcmllcyBjb21waWxlZCB3aXRoIExMVk0gY29tcGlsZXIgKEJ1ZyAj MTQ0MTkpDQoNCk9uIDA5LzI2LzIwMTIgMDg6MjMgUE0sIEtBUlRISUtWRU5L QVRFU0ggQkhBVCB3cm90ZToNCj4gVGhhbmtzIGZvciB0aGUgcmV2aWV3LiBD b21taXR0ZWQgYWZ0ZXIgZm9ybWF0dGluZy4NCg0KVGhlIGNoYW5nZWxvZyBl bnRyeSBpcyB0b28gbG9uZywgdXN1YWxseSBpdCBzaG91bGQgbm90IGV4Y2Vl ZCA3MA0KY2hhcmFjdGVycywgYW5kIHRoZXJlIGlzIGEgdHJhaWxpbmcgc3Bh Y2UuICBJIGZpeGVkIGl0IGluIHRoZQ0KcGF0Y2ggYmVsb3cuDQoNCllvdXIg cGF0Y2ggZml4ZXMgYSBQUiwgc28geW91IHNob3VsZCBhZGQgdGhlIFBSIG51 bWJlciBpbnRvIHlvdXINCmNoYW5nZWxvZyBlbnRyeSwgc28gdGhhdCBidWd6 aWxsYSBjYW4gbGluayB0aGlzIGNvbW1pdCB0byB0aGUgUFIsIGxpa2UNCnRo aXMsDQoNCg0KMjAxMi0wOS0yNiAgS2FydGhpayBCaGF0ICANCg0KUFIgYnJl YWtwb2ludHMvMTQ0MTkNCiogYXJtLXRkZXAuYyAoYXJtX3NraXBfcHJvbG9n dWUpOiBYWFhYDQotLSANCllhbw0KDQpJbmRleDogQ2hhbmdlTG9nDQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dk Yi9DaGFuZ2VMb2csdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjE0NzAwDQpk aWZmIC11IC1yMS4xNDcwMCBDaGFuZ2VMb2cNCi0tLSBDaGFuZ2VMb2cgMjYg U2VwIDIwMTIgMTI6MTQ6MzAgLTAwMDAgMS4xNDcwMA0KKysrIENoYW5nZUxv ZyAyNiBTZXAgMjAxMiAxMzozNjoxNyAtMDAwMA0KQEAgLTEsNiArMSw3IEBA DQoyMDEyLTA5LTI2ICBLYXJ0aGlrIEJoYXQgIA0KDQotICogYXJtLXRkZXAu YyAoYXJtX3NraXBfcHJvbG9ndWUpOiBFeHRlbmRpbmcgcHJvZHVjZXIgY2hl Y2sgdG8gc3VwcG9ydCBMTFZNIGNvbXBpbGVyLiANCisgKiBhcm0tdGRlcC5j IChhcm1fc2tpcF9wcm9sb2d1ZSk6IEV4dGVuZGluZyBwcm9kdWNlciBjaGVj ayB0bw0KKyBzdXBwb3J0IExMVk0gY29tcGlsZXIuDQoNCjIwMTItMDktMjYg IFNpZGRoZXNoIFBveWFyZWthciAg >From gdb-patches-return-94863-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Sep 26 14:37:40 2012 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 19655 invoked by alias); 26 Sep 2012 14:37:38 -0000 Received: (qmail 19601 invoked by uid 22791); 26 Sep 2012 14:37:36 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Sep 2012 14:37:23 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TGsjr-0004aj-DC from joseph_myers@mentor.com ; Wed, 26 Sep 2012 07:37:23 -0700 Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 26 Sep 2012 07:37:23 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.1.289.1; Wed, 26 Sep 2012 15:37:21 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1TGsjo-00009l-SC; Wed, 26 Sep 2012 14:37:20 +0000 Date: Wed, 26 Sep 2012 14:37:00 -0000 From: "Joseph S. Myers" To: Marcus Shawcroft CC: Subject: Re: [PATCH] AArch64 Port of GDB and GDBSERVER. In-Reply-To: <5062CCF0.5050203@arm.com> Message-ID: References: <5062CCF0.5050203@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org X-SW-Source: 2012-09/txt/msg00586.txt.bz2 Content-length: 1109 On Wed, 26 Sep 2012, Marcus Shawcroft wrote: > +#ifndef PTRACE_GETHBPREGS > +#define PTRACE_GETHBPREGS 29 > +#endif > + > +#ifndef PTRACE_SETHBPREGS > +#define PTRACE_SETHBPREGS 30 > +#endif > + > +#ifndef TRAP_HWBKPT > +#define TRAP_HWBKPT 0x0004 > +#endif This sort of conditional may make sense when using new definitions in an existing port, where you don't want to rely on sufficiently new kernel or glibc (as applicable) headers being used to build the native debugger. But for native code in this new port, you can assume the very latest AArch64 kernel headers (at least until the port is upstream, then you can assume the first kernel.org release with AArch64 has the minimum kernel header version you should support) and, likewise, glibc headers from the first release after that port is submitted / reviewed / committed. So I don't think such conditionals are appropriate (in the files that are only built for AArch64 host); as long as the headers you include actually do define these values, no local definitions should be needed at all. -- Joseph S. Myers joseph@codesourcery.com