Re: [PATCH/RFA] Include sh64 support for shle-*-netbsdelf*

[Elena Zannoni <ezannoni@redhat.com>]

Nick Clifton writes:
 > Hi Elena,
 > 
 > > > +  shle-*-netbsdelf*)
 > > > +    targ_defvec=bfd_elf32_shlnbsd_vec
 > > > +    targ_selvecs="bfd_elf32_shnbsd_vec shcoff_vec shlcoff_vec"
 > > > +#ifdef BFD64
 > > > +    targ_selvecs="${targ_selvecs} bfd_elf32_sh64_vec bfd_elf32_sh64l_vec bfd_elf64_sh64_vec bfd_elf64_sh64l_vec"
 > > > +#endif
 > > > +    ;;
 > > >    sh*le-*-netbsdelf*)
 > > >      targ_defvec=bfd_elf32_shlnbsd_vec
 > > >      targ_selvecs="bfd_elf32_shnbsd_vec shcoff_vec shlcoff_vec"
 > 
 > > Wouldn't the same change be required to build sh*le-*-netbdself* ?
 > 
 > Err, no.  I think that Jason's point was that support for the SH64
 > architecture was only desireable if the configure target was "sh" and
 > not "sh3" or "sh4".  Presumably "sh" is intended to mean "any SH
 > processor" whereas "sh3" means "only the SH3 processor".

Yes, I realized that.

 > 
 > > The tdep gdb file is going to be built for all the sh targets. And
 > > that file requires the sh64 disassembly functions.
 > 
 > In which case there may well be a problem.  As it stands configuring
 > BFD as, eg, sh3-elf will not bring in the sh64 architecture or
 > disassembly functions.  Can the tdep file be made conditional on the
 > SH architecture specified on the configure command line ?
 > 

No, it wouldn't be accepted. We are going towards unifying all the
targets for a given architecture, so that we can switch at runtime
with multiarch.  I mean, it is not technically impossible, but it is
philosophically inconsistent with where gdb is going nowadays. We are
even going to build multiple architectures together, like sh and ppc,
in a single executable.  As a matter of fact I had such defines when I
first submitted the port, and I removed them.

Elena


 > Cheers
 >         Nick