Re: [PATCH/RFA] Include sh64 support for shle-*-netbsdelf*

[Elena Zannoni <ezannoni@redhat.com>]

Nick Clifton writes:
 > Hi Jason,
 > 
 > >  > > +  shle-*-netbsdelf*)
 > >  > > +    targ_defvec=bfd_elf32_shlnbsd_vec
 > >  > > +    targ_selvecs="bfd_elf32_shnbsd_vec shcoff_vec shlcoff_vec"
 > >  > > +#ifdef BFD64
 > >  > > +    targ_selvecs="${targ_selvecs} bfd_elf32_sh64_vec bfd_elf32_sh64l_vec bfd_elf64_sh64_vec bfd_elf64_sh64l_vec"
 > >  > > +#endif
 > >  > > +    ;;
 > >  > >    sh*le-*-netbsdelf*)
 > >  > >      targ_defvec=bfd_elf32_shlnbsd_vec
 > >  > >      targ_selvecs="bfd_elf32_shnbsd_vec shcoff_vec shlcoff_vec"
 > >  > 
 > >  > Doesn't the "sh*le-*-netbsdelf*" target (immediately below the lines
 > >  > you have added) already cover this situation ?
 > > 
 > > It appears as if the intent in other configurations was to include sh64
 > > support only if the target was "sh", not "sh3" or "sh4", etc.  Look down
 > > one and two more, and you see the sh-*-netbsdelf* (added by hp when the
 > > sh64 code went in) and the sh*-*-netbsdelf* (added by me when I checked
 > > in NetBSD SH support) configs.
 > 
 > Oh right, I understand now.  In which case please consider this part
 > of the patch approved too.
 > 

Wouldn't the same change be required to build sh*le-*-netbdself* ?
The tdep gdb file is going to be built for all the sh targets. And that file
requires the sh64 disassembly functions.
Even the sh coff targets will require the sh64 stuff. :-(

Elena


 > Cheers
 >         Nick