From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Pedro Alves <palves@redhat.com>, Tom de Vries <tdevries@suse.de>,
gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Factor out lib/valgrind.exp
Date: Thu, 25 Oct 2018 20:03:00 -0000 [thread overview]
Message-ID: <1540497824.12106.14.camel@skynet.be> (raw)
In-Reply-To: <33486db8-dbb1-41d6-d591-f7cd3b0397dc@redhat.com>
Tom,
Thanks for doing all this.
An additional minor comment below ...
Also, for your information, before a new valgrind release,
I am re-running the valgrind gdbserver tests with various
gdb versions, and before a gdb release, I am re-running
these same valgrind tests with this new gdb candidate release.
Philippe
On Thu, 2018-10-25 at 16:25 +0100, Pedro Alves wrote:
> On 10/25/2018 04:08 PM, Tom de Vries wrote:
> > [ was: Re: [OB PATCH][gdb/testsuite] Handle removed valgrind option
> > --db-attach ]
...
> > +
> > + set test "vgdb prompt"
> > + # The trailing '.' differs for different memcheck versions.
Spurious 'trailing' comment ?
> > + gdb_test_multiple "" $test {
> > + -re " (target remote | \[^\r\n\]*/vgdb \[^\r\n\]*)\r\n" {
> > + set vgdbcmd $expect_out(1,string)
> > + pass $test
prev parent reply other threads:[~2018-10-25 20:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181024111355.GA13788@delia>
2018-10-24 16:29 ` [OB PATCH][gdb/testsuite] Handle removed valgrind option --db-attach Pedro Alves
2018-10-24 19:34 ` Tom de Vries
2018-10-24 20:50 ` Philippe Waroquiers
2018-10-25 10:09 ` Tom de Vries
2018-10-25 12:16 ` Pedro Alves
2018-10-25 14:26 ` [PATCH OB][gdb/testsuite] Move valgrind-db-attach.{c,exp} to valgrind-bt.{c,exp} Tom de Vries
2018-10-25 15:08 ` [PATCH][gdb/testsuite] Factor out lib/valgrind.exp Tom de Vries
2018-10-25 15:25 ` Pedro Alves
2018-10-25 20:03 ` Philippe Waroquiers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1540497824.12106.14.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox