From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16729 invoked by alias); 25 Oct 2018 20:03:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16717 invoked by uid 89); 25 Oct 2018 20:03:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:856 X-HELO: mailsec114.isp.belgacom.be Received: from mailsec114.isp.belgacom.be (HELO mailsec114.isp.belgacom.be) (195.238.20.110) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Oct 2018 20:03:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1540497826; x=1572033826; h=message-id:subject:from:to:date:in-reply-to:references: mime-version:content-transfer-encoding; bh=x46YVgRd64zSZfyXTuoRuT/sJC1xzEc4iTyHgGWY8YM=; b=OIZzMJ4TFkrd8+CfLpvXKZrDyummpEAdWTCT6AtuDgebRoZbWtVYE4JR GWN6d9x4KxvxuqXf3e404pdL64TCrg==; Received: from 110.212-243-81.adsl-dyn.isp.belgacom.be (HELO md) ([81.243.212.110]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 25 Oct 2018 22:03:43 +0200 Message-ID: <1540497824.12106.14.camel@skynet.be> Subject: Re: [PATCH][gdb/testsuite] Factor out lib/valgrind.exp From: Philippe Waroquiers To: Pedro Alves , Tom de Vries , gdb-patches@sourceware.org Date: Thu, 25 Oct 2018 20:03:00 -0000 In-Reply-To: <33486db8-dbb1-41d6-d591-f7cd3b0397dc@redhat.com> References: <20181024111355.GA13788@delia> <961cdab7-7882-6795-fac3-561db78d6593@redhat.com> <1540414236.12106.12.camel@skynet.be> <00acc1fb-6b79-82ff-80d3-fb770e58f77a@redhat.com> <33486db8-dbb1-41d6-d591-f7cd3b0397dc@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00591.txt.bz2 Tom, Thanks for doing all this. An additional minor comment below ... Also, for your information, before a new valgrind release, I am re-running the valgrind gdbserver tests with various gdb versions, and before a gdb release, I am re-running these same valgrind tests with this new gdb candidate release. Philippe On Thu, 2018-10-25 at 16:25 +0100, Pedro Alves wrote: > On 10/25/2018 04:08 PM, Tom de Vries wrote: > > [ was: Re: [OB PATCH][gdb/testsuite] Handle removed valgrind option > > --db-attach ] ... > > + > > + set test "vgdb prompt" > > + # The trailing '.' differs for different memcheck versions. Spurious 'trailing' comment ? > > + gdb_test_multiple "" $test { > > + -re " (target remote | \[^\r\n\]*/vgdb \[^\r\n\]*)\r\n" { > > + set vgdbcmd $expect_out(1,string) > > + pass $test