Re: [OB PATCH][gdb/testsuite] Handle removed valgrind option --db-attach

[Pedro Alves <palves@redhat.com>]

On 10/25/2018 11:09 AM, Tom de Vries wrote:
> On 10/24/18 10:50 PM, Philippe Waroquiers wrote:
>> On Wed, 2018-10-24 at 17:29 +0100, Pedro Alves wrote:
>>> But was it replaced with / renamed to something else equivalent,
>>> or the functionality completely eliminated?
>> --db-attach option functionality was removed, as it was not very
>> reliable and had a bunch of limitations e.g. not supporting threads.
>>
>> Instead, the gdbserver embedded in valgrind allows the user debug a process
>> when valgrind reports an error.
>>
>> I have put on my list of things to do to convert valgrind-attach
>> test to use vgdb (but the conversion is probably not trivial).
> 
> The valgrind-db-attach.exp test-case is very similar to the
> valgrind-infcall.exp test-case (using vgdb), so I gave it a try by
> putting the two alongside, and doing a copy/paste/replace.
> 
> OK for trunk

OK with me.  Thanks for doing this!

> (perhaps with a rename to valgrind-bt.{exp,c})?

Yeah, that sounds good.  But I'd do it as follow up, to help
archaeology, by helping git's renaming detection algorithm.

> [ Or perhaps first factor out a vgdb_start/stop or some such from
> valgrind-disp-step.exp and valgrind-infcall.exp, and then use those
> procs in valgrind-db-attach.exp instead? ]
That sounds like a very good idea.  I'd be fine to push the
current patch in as-is, and do that re-factoring on top, though,
if you'd like.

Pedro Alves