From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122451 invoked by alias); 25 Oct 2018 12:16:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121535 invoked by uid 89); 25 Oct 2018 12:16:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Oct 2018 12:16:12 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B730530C6D5C; Thu, 25 Oct 2018 12:16:03 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id B66EB614C0; Thu, 25 Oct 2018 12:16:02 +0000 (UTC) Subject: Re: [OB PATCH][gdb/testsuite] Handle removed valgrind option --db-attach To: Tom de Vries , Philippe Waroquiers , gdb-patches@sourceware.org References: <20181024111355.GA13788@delia> <961cdab7-7882-6795-fac3-561db78d6593@redhat.com> <1540414236.12106.12.camel@skynet.be> From: Pedro Alves Message-ID: <00acc1fb-6b79-82ff-80d3-fb770e58f77a@redhat.com> Date: Thu, 25 Oct 2018 12:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-10/txt/msg00572.txt.bz2 On 10/25/2018 11:09 AM, Tom de Vries wrote: > On 10/24/18 10:50 PM, Philippe Waroquiers wrote: >> On Wed, 2018-10-24 at 17:29 +0100, Pedro Alves wrote: >>> But was it replaced with / renamed to something else equivalent, >>> or the functionality completely eliminated? >> --db-attach option functionality was removed, as it was not very >> reliable and had a bunch of limitations e.g. not supporting threads. >> >> Instead, the gdbserver embedded in valgrind allows the user debug a process >> when valgrind reports an error. >> >> I have put on my list of things to do to convert valgrind-attach >> test to use vgdb (but the conversion is probably not trivial). > > The valgrind-db-attach.exp test-case is very similar to the > valgrind-infcall.exp test-case (using vgdb), so I gave it a try by > putting the two alongside, and doing a copy/paste/replace. > > OK for trunk OK with me. Thanks for doing this! > (perhaps with a rename to valgrind-bt.{exp,c})? Yeah, that sounds good. But I'd do it as follow up, to help archaeology, by helping git's renaming detection algorithm. > [ Or perhaps first factor out a vgdb_start/stop or some such from > valgrind-disp-step.exp and valgrind-infcall.exp, and then use those > procs in valgrind-db-attach.exp instead? ] That sounds like a very good idea. I'd be fine to push the current patch in as-is, and do that re-factoring on top, though, if you'd like. Pedro Alves