From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 1/2] Fix regressions for multi breakpoints command line setting/clearing
Date: Sat, 25 Aug 2018 19:17:00 -0000 [thread overview]
Message-ID: <1535224660.1438.3.camel@skynet.be> (raw)
In-Reply-To: <871sarr456.fsf@tromey.com>
On Tue, 2018-08-21 at 12:00 -0600, Tom Tromey wrote
> Philippe> + else
> Philippe> + {
> Philippe> + new_arg = arg;
> Philippe> + arg = new_arg.c_str ();
> Philippe> + }
>
> I think it should work ok now if you just remove this hunk.
Effectively, that bit of code is not needed anymore, thanks to the
fix you did for the use after free.
I will update the patch (and the test according to the comments
of Pedro), and resubmit an RFA.
Thanks
Philippe
prev parent reply other threads:[~2018-08-25 19:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 21:26 RFA " Philippe Waroquiers
2018-08-02 21:26 ` [RFA 2/2] Modify gdb.base/commands.exp to test multi breakpoint command setting/clearing Philippe Waroquiers
2018-08-16 15:54 ` Pedro Alves
2018-08-02 21:26 ` [RFA 1/2] Fix regressions for multi breakpoints command line setting/clearing Philippe Waroquiers
2018-08-03 18:29 ` Tom Tromey
2018-08-09 4:57 ` Tom Tromey
2018-08-09 20:20 ` Philippe Waroquiers
2018-08-10 0:35 ` Tom Tromey
2018-08-10 3:05 ` Tom Tromey
2018-08-10 3:13 ` Tom Tromey
2018-08-10 16:07 ` Tom Tromey
2018-08-11 20:38 ` Tom Tromey
2018-08-13 21:32 ` Philippe Waroquiers
2018-08-14 15:02 ` Pedro Alves
2018-08-14 18:33 ` Tom Tromey
2018-08-15 18:24 ` Tom Tromey
2018-08-16 15:34 ` Pedro Alves
2018-08-17 23:12 ` Tom Tromey
2018-08-21 18:01 ` Tom Tromey
2018-08-25 19:17 ` Philippe Waroquiers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535224660.1438.3.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox