From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51456 invoked by alias); 25 Aug 2018 19:17:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51446 invoked by uid 89); 25 Aug 2018 19:17:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=H*F:D*be, resubmit X-HELO: mailsec101.isp.belgacom.be Received: from mailsec101.isp.belgacom.be (HELO mailsec101.isp.belgacom.be) (195.238.20.97) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 25 Aug 2018 19:17:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1535224663; x=1566760663; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=ipEGs+LciEcMR3UehyT/arrogEoOraqi0CSqrTagwCE=; b=WDKaM+iAXk40e1D2vAnvpuAdtFcAjINwNay7pgsVi77LkmQvHGa9OHSA yzwHVi3TlziY5V6QDdvxEQBb9URIOA==; Received: from 217.24-133-109.adsl-dyn.isp.belgacom.be (HELO md) ([109.133.24.217]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 25 Aug 2018 21:17:40 +0200 Message-ID: <1535224660.1438.3.camel@skynet.be> Subject: Re: [RFA 1/2] Fix regressions for multi breakpoints command line setting/clearing From: Philippe Waroquiers To: Tom Tromey Cc: gdb-patches@sourceware.org Date: Sat, 25 Aug 2018 19:17:00 -0000 In-Reply-To: <871sarr456.fsf@tromey.com> References: <20180802212613.29813-1-philippe.waroquiers@skynet.be> <20180802212613.29813-2-philippe.waroquiers@skynet.be> <871sarr456.fsf@tromey.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00616.txt.bz2 On Tue, 2018-08-21 at 12:00 -0600, Tom Tromey wrote > Philippe> + else > Philippe> + { > Philippe> + new_arg = arg; > Philippe> + arg = new_arg.c_str (); > Philippe> + } > > I think it should work ok now if you just remove this hunk. Effectively, that bit of code is not needed anymore, thanks to the fix you did for the use after free. I will update the patch (and the test according to the comments of Pedro), and resubmit an RFA. Thanks Philippe