Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>,
	gdb-patches@sourceware.org
Subject: Re: [RFA 1/2] Fix regressions for multi breakpoints command line setting/clearing
Date: Tue, 14 Aug 2018 15:02:00 -0000	[thread overview]
Message-ID: <840f67ef-2754-5d6b-9c44-83a5f815bd27@redhat.com> (raw)
In-Reply-To: <87bmaavrr6.fsf@tromey.com>

On 08/10/2018 04:13 AM, Tom Tromey wrote:
> commit aea20ede47dfca4156f19c0b41e3a1b11e724c20
> Author: Tom Tromey <tom@tromey.com>
> Date:   Sat Jul 28 11:03:09 2018 -0600
> 
>     Fix use-after-free in number_or_range_parser
>     
>     -fsanitize=address showed a use-after-free in number_or_range_parser.
>     
>     The cause was that handle_line_of_input could stash the input into
>     "saved_command_line", and then this could be freed by reentrant calls.

But why is handle_line_of_input freeing saved_command_line on reentrant calls?
"repeat" is only supposed to be set for top-level commands, I'd think?

Thanks,
Pedro Alves


  parent reply	other threads:[~2018-08-14 15:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-02 21:26 RFA " Philippe Waroquiers
2018-08-02 21:26 ` [RFA 1/2] " Philippe Waroquiers
2018-08-03 18:29   ` Tom Tromey
2018-08-09  4:57     ` Tom Tromey
2018-08-09 20:20       ` Philippe Waroquiers
2018-08-10  0:35         ` Tom Tromey
2018-08-10  3:05           ` Tom Tromey
2018-08-10  3:13             ` Tom Tromey
2018-08-10 16:07               ` Tom Tromey
2018-08-11 20:38                 ` Tom Tromey
2018-08-13 21:32                   ` Philippe Waroquiers
2018-08-14 15:02               ` Pedro Alves [this message]
2018-08-14 18:33                 ` Tom Tromey
2018-08-15 18:24                   ` Tom Tromey
2018-08-16 15:34                     ` Pedro Alves
2018-08-17 23:12                       ` Tom Tromey
2018-08-21 18:01   ` Tom Tromey
2018-08-25 19:17     ` Philippe Waroquiers
2018-08-02 21:26 ` [RFA 2/2] Modify gdb.base/commands.exp to test multi breakpoint command setting/clearing Philippe Waroquiers
2018-08-16 15:54   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=840f67ef-2754-5d6b-9c44-83a5f815bd27@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=philippe.waroquiers@skynet.be \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox