From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>,
gdb-patches@sourceware.org
Subject: Re: [RFA 1/2] Fix regressions for multi breakpoints command line setting/clearing
Date: Thu, 16 Aug 2018 15:34:00 -0000 [thread overview]
Message-ID: <21ed4c14-3131-0b35-2fba-da6afcc330e5@redhat.com> (raw)
In-Reply-To: <8736vfa3pp.fsf@tromey.com>
On 08/15/2018 07:23 PM, Tom Tromey wrote:
> Tom> I will test a new (much smaller) patch a bit later.
>
> This is hilariously simpler and seems to fix the problem.
> Let me know what you think.
I think this is the right fix. Please push.
> Pedro pointed out that the commands being read by "commands" should
> not be repeatable. This patch fixes that problem, and the
> use-after-free bug, by simply modifying read_next_line to disallow
> repetition.
I think it'd be good to expand a bit more about the use-after-free
bug here (someone reading git logs later on won't have the context).
You already had something in the previous version of the patch,
could just copy it in.
AFAICT, the "repeat" parameter of command_line_input is always 0 now,
and so could be eliminated (in a separate patch).
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-08-16 15:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 21:26 RFA " Philippe Waroquiers
2018-08-02 21:26 ` [RFA 2/2] Modify gdb.base/commands.exp to test multi breakpoint command setting/clearing Philippe Waroquiers
2018-08-16 15:54 ` Pedro Alves
2018-08-02 21:26 ` [RFA 1/2] Fix regressions for multi breakpoints command line setting/clearing Philippe Waroquiers
2018-08-03 18:29 ` Tom Tromey
2018-08-09 4:57 ` Tom Tromey
2018-08-09 20:20 ` Philippe Waroquiers
2018-08-10 0:35 ` Tom Tromey
2018-08-10 3:05 ` Tom Tromey
2018-08-10 3:13 ` Tom Tromey
2018-08-10 16:07 ` Tom Tromey
2018-08-11 20:38 ` Tom Tromey
2018-08-13 21:32 ` Philippe Waroquiers
2018-08-14 15:02 ` Pedro Alves
2018-08-14 18:33 ` Tom Tromey
2018-08-15 18:24 ` Tom Tromey
2018-08-16 15:34 ` Pedro Alves [this message]
2018-08-17 23:12 ` Tom Tromey
2018-08-21 18:01 ` Tom Tromey
2018-08-25 19:17 ` Philippe Waroquiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21ed4c14-3131-0b35-2fba-da6afcc330e5@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox