Re: GDB CVS won't build on OSF4.0's cc

[Elena Zannoni <ezannoni@cygnus.com>]

Alex, no. Sorry, but we are trying to get rid of PTR in the
gdb sources [as Kevin pointed out in another message].

Could you 'revert' these changes by changing the definitions to 
use void * and deleting the prototypes when they are not needed (everyone
of these can go, except for free_elfinfo, I think).

[see Andrew's patch: 
http://sources.redhat.com/ml/gdb-patches/2001-06/msg00077.html ]

Thanks and sorry again.

Elena

PS. I'll go through these files later and clean up some more of these.


Alexandre Oliva writes:

 > On May 29, 2001, Alexandre Oliva <aoliva@redhat.com> wrote:
 > 
 > > This patch fixes it.  I'm checking it in as obviously correct.
 > 
 > > Index: gdb/ChangeLog
 > > from  Alexandre Oliva  <aoliva@redhat.com>
 > 
 > > 	* symfile.c (compare_psymbols, compare_symbols): Declare using
 > > 	PTR, as in the definition.
 > 
 > More of the same...  Checking in...
 > 
 > Index: gdb/ChangeLog
 > 	* minsyms.c (compare_minimal_symbols): Likewise.
 > 	* coffread.c (find_targ_sec): Likewise.
 > 	* elfread.c (free_elfinfo, elf_locate_sections): Likewise.
 > 	* mipsread.c (alphacoff_locate_sections): Likewise.
 > 	* mdebugread.c (compare_blocks): Likewise.
 > Index: gdb/minsyms.c
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/minsyms.c,v
 > retrieving revision 1.16
 > diff -u -p -r1.16 minsyms.c
 > --- gdb/minsyms.c 2001/05/22 21:02:41 1.16
 > +++ gdb/minsyms.c 2001/05/29 10:33:09
 > @@ -77,7 +77,7 @@ static int msym_count;
 >  
 >  /* Prototypes for local functions. */
 >  
 > -static int compare_minimal_symbols (const void *, const void *);
 > +static int compare_minimal_symbols (const PTR, const PTR);
 >  
 >  static int
 >  compact_minimal_symbols (struct minimal_symbol *, int, struct objfile *);
 > Index: gdb/coffread.c
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/coffread.c,v
 > retrieving revision 1.17
 > diff -u -p -r1.17 coffread.c
 > --- gdb/coffread.c 2001/03/26 02:50:46 1.17
 > +++ gdb/coffread.c 2001/05/29 10:33:09
 > @@ -312,7 +312,7 @@ struct find_targ_sec_arg
 >      asection **resultp;
 >    };
 >  
 > -static void find_targ_sec (bfd *, asection *, void *);
 > +static void find_targ_sec (bfd *, asection *, PTR);
 >  
 >  static void
 >  find_targ_sec (bfd *abfd, asection *sect, PTR obj)
 > Index: gdb/elfread.c
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/elfread.c,v
 > retrieving revision 1.15
 > diff -u -p -r1.15 elfread.c
 > --- gdb/elfread.c 2001/03/06 08:21:07 1.15
 > +++ gdb/elfread.c 2001/05/29 10:33:09
 > @@ -76,7 +76,7 @@ static void elf_symfile_finish (struct o
 >  
 >  static void elf_symtab_read (struct objfile *, int);
 >  
 > -static void free_elfinfo (void *);
 > +static void free_elfinfo (PTR);
 >  
 >  static struct minimal_symbol *record_minimal_symbol_and_info (char *,
 >  							      CORE_ADDR,
 > @@ -88,7 +88,7 @@ static struct minimal_symbol *record_min
 >  							      struct objfile
 >  							      *);
 >  
 > -static void elf_locate_sections (bfd *, asection *, void *);
 > +static void elf_locate_sections (bfd *, asection *, PTR);
 >  
 >  /* We are called once per section from elf_symfile_read.  We
 >     need to examine each section we are passed, check to see
 > Index: gdb/mipsread.c
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/mipsread.c,v
 > retrieving revision 1.8
 > diff -u -p -r1.8 mipsread.c
 > --- gdb/mipsread.c 2001/03/07 02:57:08 1.8
 > +++ gdb/mipsread.c 2001/05/29 10:33:09
 > @@ -185,7 +185,7 @@ struct alphacoff_dynsecinfo
 >      asection *got_sect;		/* Section pointer for .got section */
 >    };
 >  
 > -static void alphacoff_locate_sections (bfd *, asection *, void *);
 > +static void alphacoff_locate_sections (bfd *, asection *, PTR);
 >  
 >  /* We are called once per section from read_alphacoff_dynamic_symtab.
 >     We need to examine each section we are passed, check to see
 > Index: gdb/mdebugread.c
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/mdebugread.c,v
 > retrieving revision 1.12
 > diff -u -p -r1.12 mdebugread.c
 > --- gdb/mdebugread.c 2001/03/07 02:57:08 1.12
 > +++ gdb/mdebugread.c 2001/05/29 10:33:09
 > @@ -378,7 +378,7 @@ static PTR xzalloc (unsigned int);
 >  
 >  static void sort_blocks (struct symtab *);
 >  
 > -static int compare_blocks (const void *, const void *);
 > +static int compare_blocks (const PTR, const PTR);
 >  
 >  static struct partial_symtab *new_psymtab (char *, struct objfile *);
 >  
 > 
 > -- 
 > Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
 > Red Hat GCC Developer                  aoliva@{cygnus.com, redhat.com}
 > CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
 > Free Software Evangelist    *Please* write to mailing lists, not to me