Re: GDB CVS won't build on OSF4.0's cc

[Kevin Buettner <kevinb@cygnus.com>]

On May 29,  7:19am, Alexandre Oliva wrote:

> 	* symfile.c (compare_psymbols, compare_symbols): Declare using
> 	PTR, as in the definition.
> 
> Index: gdb/symfile.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/symfile.c,v
> retrieving revision 1.32
> diff -u -p -r1.32 symfile.c
> --- gdb/symfile.c 2001/05/10 15:33:21 1.32
> +++ gdb/symfile.c 2001/05/29 10:18:16
> @@ -117,9 +117,9 @@ static void add_shared_symbol_files_comm
>  
>  static void cashier_psymtab (struct partial_symtab *);
>  
> -static int compare_psymbols (const void *, const void *);
> +static int compare_psymbols (const PTR, const PTR);
>  
> -static int compare_symbols (const void *, const void *);
> +static int compare_symbols (const PTR, const PTR);
>  
>  bfd *symfile_bfd_open (char *);

I'm not the maintainer of the file in question, but one of our long
term goals has been the elimination of PTR from the gdb sources.  I
think the fix should have been to change PTR in the definition to
void * rather than change the declaration to match the definition.

Kevin