* [PATCH] Fix --host cris-*-linux build of GDBServer.
@ 2015-10-21 10:01 Antoine Tremblay
2015-10-21 10:38 ` Yao Qi
0 siblings, 1 reply; 3+ messages in thread
From: Antoine Tremblay @ 2015-10-21 10:01 UTC (permalink / raw)
To: gdb-patches; +Cc: Antoine Tremblay
Compiling GDBServer with --host cris-*-linux yields a compilation error :
linux-cris-low.c:65:21: error: ‘void’ must be the only parameter
This patch fixes the issue by removing the void parameter in cris_get_pc.
gdb/gdbserver/ChangeLog:
* linux-cris-low.c (cris_get_pc): Remove void arg.
---
gdb/gdbserver/linux-cris-low.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/gdbserver/linux-cris-low.c b/gdb/gdbserver/linux-cris-low.c
index e0bfa1a..135e37a 100644
--- a/gdb/gdbserver/linux-cris-low.c
+++ b/gdb/gdbserver/linux-cris-low.c
@@ -62,7 +62,7 @@ cris_cannot_fetch_register (int regno)
extern int debug_threads;
static CORE_ADDR
-cris_get_pc (struct regcache *regcache, void)
+cris_get_pc (struct regcache *regcache)
{
unsigned long pc;
collect_register_by_name (regcache, "pc", &pc);
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix --host cris-*-linux build of GDBServer.
2015-10-21 10:01 [PATCH] Fix --host cris-*-linux build of GDBServer Antoine Tremblay
@ 2015-10-21 10:38 ` Yao Qi
2015-10-21 13:47 ` Antoine Tremblay
0 siblings, 1 reply; 3+ messages in thread
From: Yao Qi @ 2015-10-21 10:38 UTC (permalink / raw)
To: Antoine Tremblay, gdb-patches
On 20/10/15 20:24, Antoine Tremblay wrote:
> Compiling GDBServer with --host cris-*-linux yields a compilation error :
>
> linux-cris-low.c:65:21: error: ‘void’ must be the only parameter
>
> This patch fixes the issue by removing the void parameter in cris_get_pc.
>
> gdb/gdbserver/ChangeLog:
> * linux-cris-low.c (cris_get_pc): Remove void arg.
The change is obvious, and patch is OK to me. Thanks for splitting
it out of your ARM GDBserver breakpoint patches.
--
Yao (é½å°§)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix --host cris-*-linux build of GDBServer.
2015-10-21 10:38 ` Yao Qi
@ 2015-10-21 13:47 ` Antoine Tremblay
0 siblings, 0 replies; 3+ messages in thread
From: Antoine Tremblay @ 2015-10-21 13:47 UTC (permalink / raw)
To: Yao Qi, gdb-patches
On 10/21/2015 04:18 AM, Yao Qi wrote:
> On 20/10/15 20:24, Antoine Tremblay wrote:
>> Compiling GDBServer with --host cris-*-linux yields a compilation error :
>>
>> linux-cris-low.c:65:21: error: ‘void’ must be the only parameter
>>
>> This patch fixes the issue by removing the void parameter in cris_get_pc.
>>
>> gdb/gdbserver/ChangeLog:
>> * linux-cris-low.c (cris_get_pc): Remove void arg.
>
> The change is obvious, and patch is OK to me. Thanks for splitting
> it out of your ARM GDBserver breakpoint patches.
>
Pushed. Yes, it's obvious I guess I'm overly cautious.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-21 11:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-21 10:01 [PATCH] Fix --host cris-*-linux build of GDBServer Antoine Tremblay
2015-10-21 10:38 ` Yao Qi
2015-10-21 13:47 ` Antoine Tremblay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox