From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106545 invoked by alias); 21 Oct 2015 11:49:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106521 invoked by uid 89); 21 Oct 2015 11:49:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 21 Oct 2015 11:49:56 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id EE.9F.32596.A4B17265; Wed, 21 Oct 2015 06:57:46 +0200 (CEST) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.83) with Microsoft SMTP Server id 14.3.248.2; Wed, 21 Oct 2015 07:49:53 -0400 Subject: Re: [PATCH] Fix --host cris-*-linux build of GDBServer. To: Yao Qi , References: <1445369050-18033-1-git-send-email-antoine.tremblay@ericsson.com> <56274A63.2010404@gmail.com> From: Antoine Tremblay Message-ID: <56277BE1.6000207@ericsson.com> Date: Wed, 21 Oct 2015 13:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56274A63.2010404@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00404.txt.bz2 On 10/21/2015 04:18 AM, Yao Qi wrote: > On 20/10/15 20:24, Antoine Tremblay wrote: >> Compiling GDBServer with --host cris-*-linux yields a compilation error : >> >> linux-cris-low.c:65:21: error: =E2=80=98void=E2=80=99 must be the only p= arameter >> >> This patch fixes the issue by removing the void parameter in cris_get_pc. >> >> gdb/gdbserver/ChangeLog: >> * linux-cris-low.c (cris_get_pc): Remove void arg. > > The change is obvious, and patch is OK to me. Thanks for splitting > it out of your ARM GDBserver breakpoint patches. > Pushed. Yes, it's obvious I guess I'm overly cautious.