From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: Yao Qi <qiyaoltc@gmail.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix --host cris-*-linux build of GDBServer.
Date: Wed, 21 Oct 2015 13:47:00 -0000 [thread overview]
Message-ID: <56277BE1.6000207@ericsson.com> (raw)
In-Reply-To: <56274A63.2010404@gmail.com>
On 10/21/2015 04:18 AM, Yao Qi wrote:
> On 20/10/15 20:24, Antoine Tremblay wrote:
>> Compiling GDBServer with --host cris-*-linux yields a compilation error :
>>
>> linux-cris-low.c:65:21: error: ‘void’ must be the only parameter
>>
>> This patch fixes the issue by removing the void parameter in cris_get_pc.
>>
>> gdb/gdbserver/ChangeLog:
>> * linux-cris-low.c (cris_get_pc): Remove void arg.
>
> The change is obvious, and patch is OK to me. Thanks for splitting
> it out of your ARM GDBserver breakpoint patches.
>
Pushed. Yes, it's obvious I guess I'm overly cautious.
prev parent reply other threads:[~2015-10-21 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 10:01 Antoine Tremblay
2015-10-21 10:38 ` Yao Qi
2015-10-21 13:47 ` Antoine Tremblay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56277BE1.6000207@ericsson.com \
--to=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox