[PATCH v2] Add comment for mi_run_cmd_full

[PATCH v2] Add comment for mi_run_cmd_full

[Simon Marchi]

It should clear up confusion about the args parameter to mi_run_cmd_full.

Thanks to Joel for the clear formulation. I also added a comment about the
impact of use_gdb_stub.

gdb/testsuite/ChangeLog:

2014-05-22  Simon Marchi  <simon.marchi@ericsson.com>

	* lib/mi-support.exp (mi_run_cmd_full): Add comments.
---
 gdb/testsuite/lib/mi-support.exp | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-support.exp
index 09a514b..9f07cda 100644
--- a/gdb/testsuite/lib/mi-support.exp
+++ b/gdb/testsuite/lib/mi-support.exp
@@ -830,6 +830,18 @@ proc mi_gdb_expect_cli_output {until message} {
 # In patterns, the newline sequence ``\r\n'' is matched explicitly as
 # ``.*$'' could swallow up output that we attempt to match elsewhere.
 
+# Send the command to run the test program.
+#
+# If USE_MI_COMMAND is true, the "-exec-run" command is used.
+# Otherwise, the "run" (CLI) command is used.  If the global USE_GDB_STUB is
+# true, -exec-continue and continue are used instead of their run counterparts.
+#
+# ARGS is passed as argument to the command used to run the test program.
+# Beware that arguments to "-exec-run" do not have the same semantics as
+# arguments to the "run" command, so USE_MI_COMMAND influences the meaning
+# of ARGS.  If USE_MI_COMMAND is true, they are arguments to -exec-run.
+# If USE_MI_COMMAND is false, they are effectively arguments passed
+# to the test program.  If the global USE_GDB_STUB is true, ARGS is not used.
 proc mi_run_cmd_full {use_mi_command args} {
     global suppress_flag
     if { $suppress_flag } {
-- 
2.0.0.rc0

Re: [PATCH v2] Add comment for mi_run_cmd_full

[Joel Brobecker]

> Thanks to Joel for the clear formulation. I also added a comment about the
> impact of use_gdb_stub.

A useful addition, as I missed it when I read the function's code!

> gdb/testsuite/ChangeLog:
> 
> 2014-05-22  Simon Marchi  <simon.marchi@ericsson.com>
> 
> 	* lib/mi-support.exp (mi_run_cmd_full): Add comments.

OK to push.

Thank you!
-- 
Joel

Re: [PATCH v2] Add comment for mi_run_cmd_full

[Simon Marchi]

On Thu 22 May 2014 02:11:42 PM EDT, Joel Brobecker wrote:
>> Thanks to Joel for the clear formulation. I also added a comment about the
>> impact of use_gdb_stub.
>
> A useful addition, as I missed it when I read the function's code!
>
>> gdb/testsuite/ChangeLog:
>>
>> 2014-05-22  Simon Marchi  <simon.marchi@ericsson.com>
>>
>> 	* lib/mi-support.exp (mi_run_cmd_full): Add comments.
>
> OK to push.
>
> Thank you!

Pushed!