From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21727 invoked by alias); 22 May 2014 18:02:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21713 invoked by uid 89); 22 May 2014 18:02:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 22 May 2014 18:02:20 +0000 Received: from EUSAAHC006.ericsson.se (Unknown_Domain [147.117.188.90]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 46.C0.27529.0EBED735; Thu, 22 May 2014 14:21:52 +0200 (CEST) Received: from simark-hp.mo.ca.am.ericsson.se (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.90) with Microsoft SMTP Server (TLS) id 14.3.174.1; Thu, 22 May 2014 14:02:13 -0400 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH v2] Add comment for mi_run_cmd_full Date: Thu, 22 May 2014 18:02:00 -0000 Message-ID: <1400781727-8421-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00564.txt.bz2 It should clear up confusion about the args parameter to mi_run_cmd_full. Thanks to Joel for the clear formulation. I also added a comment about the impact of use_gdb_stub. gdb/testsuite/ChangeLog: 2014-05-22 Simon Marchi * lib/mi-support.exp (mi_run_cmd_full): Add comments. --- gdb/testsuite/lib/mi-support.exp | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-support.exp index 09a514b..9f07cda 100644 --- a/gdb/testsuite/lib/mi-support.exp +++ b/gdb/testsuite/lib/mi-support.exp @@ -830,6 +830,18 @@ proc mi_gdb_expect_cli_output {until message} { # In patterns, the newline sequence ``\r\n'' is matched explicitly as # ``.*$'' could swallow up output that we attempt to match elsewhere. +# Send the command to run the test program. +# +# If USE_MI_COMMAND is true, the "-exec-run" command is used. +# Otherwise, the "run" (CLI) command is used. If the global USE_GDB_STUB is +# true, -exec-continue and continue are used instead of their run counterparts. +# +# ARGS is passed as argument to the command used to run the test program. +# Beware that arguments to "-exec-run" do not have the same semantics as +# arguments to the "run" command, so USE_MI_COMMAND influences the meaning +# of ARGS. If USE_MI_COMMAND is true, they are arguments to -exec-run. +# If USE_MI_COMMAND is false, they are effectively arguments passed +# to the test program. If the global USE_GDB_STUB is true, ARGS is not used. proc mi_run_cmd_full {use_mi_command args} { global suppress_flag if { $suppress_flag } { -- 2.0.0.rc0