From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26738 invoked by alias); 22 May 2014 18:11:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26627 invoked by uid 89); 22 May 2014 18:11:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 22 May 2014 18:11:43 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E551A116216; Thu, 22 May 2014 14:11:41 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id oQdUnrnQlLKm; Thu, 22 May 2014 14:11:41 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B095711621E; Thu, 22 May 2014 14:11:41 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1AE7E40025; Thu, 22 May 2014 11:11:42 -0700 (PDT) Date: Thu, 22 May 2014 18:11:00 -0000 From: Joel Brobecker To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Add comment for mi_run_cmd_full Message-ID: <20140522181142.GU22822@adacore.com> References: <1400781727-8421-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1400781727-8421-1-git-send-email-simon.marchi@ericsson.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-05/txt/msg00565.txt.bz2 > Thanks to Joel for the clear formulation. I also added a comment about the > impact of use_gdb_stub. A useful addition, as I missed it when I read the function's code! > gdb/testsuite/ChangeLog: > > 2014-05-22 Simon Marchi > > * lib/mi-support.exp (mi_run_cmd_full): Add comments. OK to push. Thank you! -- Joel