From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 1/3] set trust-readonly-sections off in test cases
Date: Fri, 06 Sep 2013 02:03:00 -0000 [thread overview]
Message-ID: <1378432920-7731-2-git-send-email-yao@codesourcery.com> (raw)
In-Reply-To: <1378432920-7731-1-git-send-email-yao@codesourcery.com>
In the test cases, if GDB modified code in the inferior, it should
'set trust-readonly-sections off' too. Similarly, users has to set it
off if users modified code for some purpose.
gdb/testsuite:
2013-09-06 Yao Qi <yao@codesourcery.com>
* gdb.base/break-always.exp: Set trust-readonly-sections off.
* gdb.mi/mi-fill-memory.exp: Likewise.
gdb/doc:
2013-09-06 Yao Qi <yao@codesourcery.com>
* gdb.texinfo (File): Mention that user has
'set trust-readonly-sections off' to get updated contents if
they are modified.
---
gdb/doc/gdb.texinfo | 5 ++++-
gdb/testsuite/gdb.base/break-always.exp | 4 ++++
gdb/testsuite/gdb.mi/mi-fill-memory.exp | 5 +++++
3 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 21250fe..d8e4adf 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -16678,7 +16678,10 @@ The default is off.
@item set trust-readonly-sections off
Tell @value{GDBN} not to trust readonly sections. This means that
the contents of the section might change while the program is running,
-and must therefore be fetched from the target when needed.
+and must therefore be fetched from the target when needed. If user
+modified the code in the target program, user has to
+@code{set trust-readonly-sections off} to guarantee @value{GDBN} reads
+updated contents from the target program instead of object file.
@item show trust-readonly-sections
Show the current setting of trusting readonly sections.
diff --git a/gdb/testsuite/gdb.base/break-always.exp b/gdb/testsuite/gdb.base/break-always.exp
index b0a9faf..16f6d47 100644
--- a/gdb/testsuite/gdb.base/break-always.exp
+++ b/gdb/testsuite/gdb.base/break-always.exp
@@ -69,6 +69,10 @@ gdb_test "p /x \$shadow = *(char *) $bp_address" \
# and still leave the breakpoint insn planted. Try twice with
# different values, in case we happen to be writting exactly what was
# there already.
+# Turn option "trust-readonly-sections" off to force GDB to read
+# contents from the target instead of the object file.
+gdb_test_no_output "set trust-readonly-sections off"
+
gdb_test "p /x *(char *) $bp_address = 0" \
" = 0x0" \
"write 0 to breakpoint's address"
diff --git a/gdb/testsuite/gdb.mi/mi-fill-memory.exp b/gdb/testsuite/gdb.mi/mi-fill-memory.exp
index 5f68cbb..ac9313b 100644
--- a/gdb/testsuite/gdb.mi/mi-fill-memory.exp
+++ b/gdb/testsuite/gdb.mi/mi-fill-memory.exp
@@ -51,6 +51,11 @@ mi_gdb_test "4-data-write-memory-bytes \$pc ab 8"\
"4\\\^done" \
"memory successfully filled (8 bytes)"
+# Turn option "trust-readonly-sections" off to force GDB to read
+# contents from the target instead of the object file.
+mi_gdb_test "-gdb-set trust-readonly-sections off" "\\\^done" \
+ "set trust-readonly-sections off"
+
mi_gdb_test "5-interpreter-exec console \"x \$pc\"" \
".*0xabababab.*" \
"pattern correctly read from memory"
--
1.7.7.6
next prev parent reply other threads:[~2013-09-06 2:03 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 2:03 [PATCH 0/3] Trust readonly sections if target has memory protection Yao Qi
2013-09-06 2:03 ` Yao Qi [this message]
2013-09-06 5:56 ` [PATCH 1/3] set trust-readonly-sections off in test cases Eli Zaretskii
2013-09-06 17:23 ` Pedro Alves
2013-09-06 2:03 ` [PATCH 2/3] Trust readonly sections if target has memory protection Yao Qi
2013-09-06 6:05 ` Eli Zaretskii
2013-09-06 9:07 ` Yao Qi
2013-09-06 9:24 ` Eli Zaretskii
2013-09-06 2:03 ` [PATCH 3/3] Linux " Yao Qi
2013-09-06 5:57 ` [PATCH 0/3] Trust readonly sections if target " Eli Zaretskii
2013-09-06 8:24 ` Yao Qi
2013-09-06 8:45 ` Eli Zaretskii
2013-09-06 13:03 ` Joel Brobecker
2013-09-06 13:27 ` Yao Qi
2013-09-06 13:32 ` Eli Zaretskii
2013-09-06 14:17 ` Pierre Muller
[not found] ` <"000d01ceab0b$d53ae600$7fb0b200$@muller"@ics-cnrs.unistra.fr>
2013-09-06 14:38 ` Eli Zaretskii
2013-09-06 14:52 ` Joel Brobecker
2013-09-06 15:56 ` Eli Zaretskii
2013-09-06 18:10 ` Joel Brobecker
2013-09-06 18:36 ` Eli Zaretskii
2013-09-06 13:00 ` Joel Brobecker
2013-09-08 12:04 ` [PATCH 0/7 V2] " Yao Qi
2013-09-08 12:04 ` [PATCH 1/7] Emit a warning when writing to a readonly section and trust_readonly is true Yao Qi
2013-09-08 15:10 ` Eli Zaretskii
2013-09-08 12:05 ` [PATCH 4/7] Trust readonly sections if target has memory protection Yao Qi
2013-09-08 15:13 ` Eli Zaretskii
2013-09-09 7:49 ` Yao Qi
2013-09-09 16:25 ` Eli Zaretskii
2013-09-08 12:05 ` [PATCH 3/7] New function windows_init_abi Yao Qi
2013-09-08 12:05 ` [PATCH 2/7] set trust-readonly-sections off in test cases Yao Qi
2013-09-08 12:05 ` [PATCH 7/7] Windows has memory protection Yao Qi
2013-09-08 12:05 ` [PATCH 5/7] DOC and NEWS Yao Qi
2013-09-08 12:05 ` [PATCH 6/7] Linux has memory protection Yao Qi
2013-09-09 19:16 ` [PATCH 0/7 V2] Trust readonly sections if target " Mark Kettenis
2013-09-10 4:06 ` Yao Qi
2013-09-12 8:30 ` Yao Qi
2013-09-12 9:49 ` Mark Kettenis
2013-09-13 8:17 ` Yao Qi
2013-09-30 17:50 ` Pedro Alves
2013-09-30 18:08 ` Pedro Alves
2013-10-07 22:29 ` Stan Shebs
2013-10-08 12:18 ` Pedro Alves
2013-10-08 12:47 ` Abid, Hafiz
2013-10-08 13:36 ` tmirza
2013-10-09 2:24 ` Doug Evans
2013-10-23 10:16 ` Yao Qi
2013-10-15 0:44 ` Yao Qi
2013-09-20 2:47 ` [PATCH 0/7 V3] " Yao Qi
2013-09-20 2:47 ` [PATCH 7/7] Windows " Yao Qi
2013-09-20 2:47 ` [PATCH 1/7] Emit a query when writing to a readonly section and trust_readonly is true Yao Qi
2013-09-20 2:47 ` [PATCH 4/7] Trust readonly sections if target has memory protection and in remote debugging Yao Qi
2013-09-20 2:47 ` [PATCH 5/7] DOC and NEWS Yao Qi
2013-09-20 8:21 ` Eli Zaretskii
2013-09-20 2:47 ` [PATCH 2/7] set trust-readonly-sections off in test cases Yao Qi
2013-09-20 2:47 ` [PATCH 6/7] Linux has memory protection Yao Qi
2013-09-20 2:47 ` [PATCH 3/7] New function windows_init_abi Yao Qi
2013-09-30 18:23 ` Pedro Alves
2013-10-01 6:47 ` Yao Qi
2013-10-01 9:35 ` Pedro Alves
2013-10-01 13:23 ` Yao Qi
2013-09-29 13:51 ` [PATCH 0/7 V3] Trust readonly sections if target has memory protection Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378432920-7731-2-git-send-email-yao@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox