Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 0/7 V3] Trust readonly sections if target has memory protection
Date: Fri, 20 Sep 2013 02:47:00 -0000	[thread overview]
Message-ID: <1379645226-8719-1-git-send-email-yao@codesourcery.com> (raw)
In-Reply-To: <1378641807-24256-1-git-send-email-yao@codesourcery.com>

Hello,
Here is the V3, to address two comments to V2.

 - Give a yes-or-no query when read-only address is modified and
   trust-readonly-sections is on.  See patch 1/7.  A test case
   gdb.base/trust-readonly.exp is added too.
 - Enable trust-readonly-sections on all linux and windows targets
   for remote debugging only.  It is different from what I proposed,
   {x86, x86_64}-{linux,mingw,cygwin}, because it looks odd to enable
   this feature only on x86*-linux targets and disable it on the rest of
   linux targets.  See patch 4/7.

Patch 2/7, 3/7, 6/7 and 7/7 are unchanged.  Since the condition on
trusting readonly-sections is restricted (only on remote debugging),
so the doc (patch 5/7) is updated as well.

V2 can be found https://sourceware.org/ml/gdb-patches/2013-09/msg00258.html

*** BLURB HERE ***

Yao Qi (7):
  Emit a warning when writing to a readonly section and trust_readonly
    is true
  set trust-readonly-sections off in test cases
  New function windows_init_abi
  Trust readonly sections if target has memory protection and in remote
    debugging
  DOC and NEWS
  Linux has memory protection.
  Windows has memory protection

 gdb/NEWS                                  |    5 ++
 gdb/amd64-windows-tdep.c                  |    5 +-
 gdb/arch-utils.c                          |    7 +++
 gdb/arch-utils.h                          |    2 +
 gdb/doc/gdb.texinfo                       |   12 ++++-
 gdb/gdbarch.c                             |   24 ++++++++
 gdb/gdbarch.h                             |    6 ++
 gdb/gdbarch.sh                            |    3 +
 gdb/i386-cygwin-tdep.c                    |    9 +---
 gdb/linux-tdep.c                          |   10 ++++
 gdb/target.c                              |   70 ++++++++++++++++++------
 gdb/testsuite/gdb.base/break-always.exp   |    4 ++
 gdb/testsuite/gdb.base/trust-readonly.exp |   85 +++++++++++++++++++++++++++++
 gdb/testsuite/gdb.mi/mi-fill-memory.exp   |    5 ++
 gdb/windows-tdep.c                        |   31 ++++++++++-
 gdb/windows-tdep.h                        |    6 +--
 16 files changed, 250 insertions(+), 34 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/trust-readonly.exp

-- 
1.7.7.6


  parent reply	other threads:[~2013-09-20  2:47 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06  2:03 [PATCH 0/3] " Yao Qi
2013-09-06  2:03 ` [PATCH 3/3] Linux " Yao Qi
2013-09-06  2:03 ` [PATCH 2/3] Trust readonly sections if target " Yao Qi
2013-09-06  6:05   ` Eli Zaretskii
2013-09-06  9:07     ` Yao Qi
2013-09-06  9:24       ` Eli Zaretskii
2013-09-06  2:03 ` [PATCH 1/3] set trust-readonly-sections off in test cases Yao Qi
2013-09-06  5:56   ` Eli Zaretskii
2013-09-06 17:23   ` Pedro Alves
2013-09-06  5:57 ` [PATCH 0/3] Trust readonly sections if target has memory protection Eli Zaretskii
2013-09-06  8:24   ` Yao Qi
2013-09-06  8:45     ` Eli Zaretskii
2013-09-06 13:03       ` Joel Brobecker
2013-09-06 13:27         ` Yao Qi
2013-09-06 13:32         ` Eli Zaretskii
2013-09-06 14:17           ` Pierre Muller
     [not found]           ` <"000d01ceab0b$d53ae600$7fb0b200$@muller"@ics-cnrs.unistra.fr>
2013-09-06 14:38             ` Eli Zaretskii
2013-09-06 14:52           ` Joel Brobecker
2013-09-06 15:56             ` Eli Zaretskii
2013-09-06 18:10               ` Joel Brobecker
2013-09-06 18:36                 ` Eli Zaretskii
2013-09-06 13:00 ` Joel Brobecker
2013-09-08 12:04 ` [PATCH 0/7 V2] " Yao Qi
2013-09-08 12:04   ` [PATCH 1/7] Emit a warning when writing to a readonly section and trust_readonly is true Yao Qi
2013-09-08 15:10     ` Eli Zaretskii
2013-09-08 12:05   ` [PATCH 6/7] Linux has memory protection Yao Qi
2013-09-08 12:05   ` [PATCH 5/7] DOC and NEWS Yao Qi
2013-09-08 12:05   ` [PATCH 2/7] set trust-readonly-sections off in test cases Yao Qi
2013-09-08 12:05   ` [PATCH 7/7] Windows has memory protection Yao Qi
2013-09-08 12:05   ` [PATCH 3/7] New function windows_init_abi Yao Qi
2013-09-08 12:05   ` [PATCH 4/7] Trust readonly sections if target has memory protection Yao Qi
2013-09-08 15:13     ` Eli Zaretskii
2013-09-09  7:49       ` Yao Qi
2013-09-09 16:25         ` Eli Zaretskii
2013-09-09 19:16   ` [PATCH 0/7 V2] " Mark Kettenis
2013-09-10  4:06     ` Yao Qi
2013-09-12  8:30       ` Yao Qi
2013-09-12  9:49         ` Mark Kettenis
2013-09-13  8:17           ` Yao Qi
2013-09-30 17:50             ` Pedro Alves
2013-09-30 18:08               ` Pedro Alves
2013-10-07 22:29                 ` Stan Shebs
2013-10-08 12:18                   ` Pedro Alves
2013-10-08 12:47                     ` Abid, Hafiz
2013-10-08 13:36                       ` tmirza
2013-10-09  2:24               ` Doug Evans
2013-10-23 10:16                 ` Yao Qi
2013-10-15  0:44               ` Yao Qi
2013-09-20  2:47   ` Yao Qi [this message]
2013-09-20  2:47     ` [PATCH 7/7] Windows " Yao Qi
2013-09-20  2:47     ` [PATCH 1/7] Emit a query when writing to a readonly section and trust_readonly is true Yao Qi
2013-09-20  2:47     ` [PATCH 4/7] Trust readonly sections if target has memory protection and in remote debugging Yao Qi
2013-09-20  2:47     ` [PATCH 5/7] DOC and NEWS Yao Qi
2013-09-20  8:21       ` Eli Zaretskii
2013-09-20  2:47     ` [PATCH 2/7] set trust-readonly-sections off in test cases Yao Qi
2013-09-20  2:47     ` [PATCH 6/7] Linux has memory protection Yao Qi
2013-09-20  2:47     ` [PATCH 3/7] New function windows_init_abi Yao Qi
2013-09-30 18:23       ` Pedro Alves
2013-10-01  6:47         ` Yao Qi
2013-10-01  9:35           ` Pedro Alves
2013-10-01 13:23             ` Yao Qi
2013-09-29 13:51     ` [PATCH 0/7 V3] Trust readonly sections if target has memory protection Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379645226-8719-1-git-send-email-yao@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox