Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] set trust-readonly-sections off in test cases
Date: Fri, 06 Sep 2013 05:56:00 -0000	[thread overview]
Message-ID: <83vc2emr2o.fsf@gnu.org> (raw)
In-Reply-To: <1378432920-7731-2-git-send-email-yao@codesourcery.com>

> From: Yao Qi <yao@codesourcery.com>
> Date: Fri, 6 Sep 2013 10:01:58 +0800
> 
> 2013-09-06  Yao Qi  <yao@codesourcery.com>
> 
> 	* gdb.texinfo (File): Mention that user has
> 	'set trust-readonly-sections off' to get updated contents if
> 	they are modified.

Thanks.

>  @item set trust-readonly-sections off
>  Tell @value{GDBN} not to trust readonly sections.  This means that
>  the contents of the section might change while the program is running,
> -and must therefore be fetched from the target when needed.
> +and must therefore be fetched from the target when needed.  If user
> +modified the code in the target program, user has to
> +@code{set trust-readonly-sections off} to guarantee @value{GDBN} reads
> +updated contents from the target program instead of object file.

Please don't talk about the user in the "third-person" style.  Please
use "you" instead.

Also, if this patch series turns the flag on, we should change the
sentence above this text that says default is off, and announce that
in NEWS.


  reply	other threads:[~2013-09-06  5:56 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06  2:03 [PATCH 0/3] Trust readonly sections if target has memory protection Yao Qi
2013-09-06  2:03 ` [PATCH 3/3] Linux " Yao Qi
2013-09-06  2:03 ` [PATCH 1/3] set trust-readonly-sections off in test cases Yao Qi
2013-09-06  5:56   ` Eli Zaretskii [this message]
2013-09-06 17:23   ` Pedro Alves
2013-09-06  2:03 ` [PATCH 2/3] Trust readonly sections if target has memory protection Yao Qi
2013-09-06  6:05   ` Eli Zaretskii
2013-09-06  9:07     ` Yao Qi
2013-09-06  9:24       ` Eli Zaretskii
2013-09-06  5:57 ` [PATCH 0/3] " Eli Zaretskii
2013-09-06  8:24   ` Yao Qi
2013-09-06  8:45     ` Eli Zaretskii
2013-09-06 13:03       ` Joel Brobecker
2013-09-06 13:27         ` Yao Qi
2013-09-06 13:32         ` Eli Zaretskii
2013-09-06 14:17           ` Pierre Muller
     [not found]           ` <"000d01ceab0b$d53ae600$7fb0b200$@muller"@ics-cnrs.unistra.fr>
2013-09-06 14:38             ` Eli Zaretskii
2013-09-06 14:52           ` Joel Brobecker
2013-09-06 15:56             ` Eli Zaretskii
2013-09-06 18:10               ` Joel Brobecker
2013-09-06 18:36                 ` Eli Zaretskii
2013-09-06 13:00 ` Joel Brobecker
2013-09-08 12:04 ` [PATCH 0/7 V2] " Yao Qi
2013-09-08 12:04   ` [PATCH 1/7] Emit a warning when writing to a readonly section and trust_readonly is true Yao Qi
2013-09-08 15:10     ` Eli Zaretskii
2013-09-08 12:05   ` [PATCH 6/7] Linux has memory protection Yao Qi
2013-09-08 12:05   ` [PATCH 5/7] DOC and NEWS Yao Qi
2013-09-08 12:05   ` [PATCH 2/7] set trust-readonly-sections off in test cases Yao Qi
2013-09-08 12:05   ` [PATCH 7/7] Windows has memory protection Yao Qi
2013-09-08 12:05   ` [PATCH 4/7] Trust readonly sections if target " Yao Qi
2013-09-08 15:13     ` Eli Zaretskii
2013-09-09  7:49       ` Yao Qi
2013-09-09 16:25         ` Eli Zaretskii
2013-09-08 12:05   ` [PATCH 3/7] New function windows_init_abi Yao Qi
2013-09-09 19:16   ` [PATCH 0/7 V2] Trust readonly sections if target has memory protection Mark Kettenis
2013-09-10  4:06     ` Yao Qi
2013-09-12  8:30       ` Yao Qi
2013-09-12  9:49         ` Mark Kettenis
2013-09-13  8:17           ` Yao Qi
2013-09-30 17:50             ` Pedro Alves
2013-09-30 18:08               ` Pedro Alves
2013-10-07 22:29                 ` Stan Shebs
2013-10-08 12:18                   ` Pedro Alves
2013-10-08 12:47                     ` Abid, Hafiz
2013-10-08 13:36                       ` tmirza
2013-10-09  2:24               ` Doug Evans
2013-10-23 10:16                 ` Yao Qi
2013-10-15  0:44               ` Yao Qi
2013-09-20  2:47   ` [PATCH 0/7 V3] " Yao Qi
2013-09-20  2:47     ` [PATCH 5/7] DOC and NEWS Yao Qi
2013-09-20  8:21       ` Eli Zaretskii
2013-09-20  2:47     ` [PATCH 2/7] set trust-readonly-sections off in test cases Yao Qi
2013-09-20  2:47     ` [PATCH 6/7] Linux has memory protection Yao Qi
2013-09-20  2:47     ` [PATCH 3/7] New function windows_init_abi Yao Qi
2013-09-30 18:23       ` Pedro Alves
2013-10-01  6:47         ` Yao Qi
2013-10-01  9:35           ` Pedro Alves
2013-10-01 13:23             ` Yao Qi
2013-09-20  2:47     ` [PATCH 7/7] Windows has memory protection Yao Qi
2013-09-20  2:47     ` [PATCH 1/7] Emit a query when writing to a readonly section and trust_readonly is true Yao Qi
2013-09-20  2:47     ` [PATCH 4/7] Trust readonly sections if target has memory protection and in remote debugging Yao Qi
2013-09-29 13:51     ` [PATCH 0/7 V3] Trust readonly sections if target has memory protection Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83vc2emr2o.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox