From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21163 invoked by alias); 6 Sep 2013 02:03:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21058 invoked by uid 89); 6 Sep 2013 02:03:07 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Sep 2013 02:03:07 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VHlO2-0006nJ-8D from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Thu, 05 Sep 2013 19:03:02 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 5 Sep 2013 19:03:02 -0700 Received: from qiyao.dyndns.org.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.2.247.3; Thu, 5 Sep 2013 19:03:01 -0700 From: Yao Qi To: Subject: [PATCH 1/3] set trust-readonly-sections off in test cases Date: Fri, 06 Sep 2013 02:03:00 -0000 Message-ID: <1378432920-7731-2-git-send-email-yao@codesourcery.com> In-Reply-To: <1378432920-7731-1-git-send-email-yao@codesourcery.com> References: <1378432920-7731-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00195.txt.bz2 In the test cases, if GDB modified code in the inferior, it should 'set trust-readonly-sections off' too. Similarly, users has to set it off if users modified code for some purpose. gdb/testsuite: 2013-09-06 Yao Qi * gdb.base/break-always.exp: Set trust-readonly-sections off. * gdb.mi/mi-fill-memory.exp: Likewise. gdb/doc: 2013-09-06 Yao Qi * gdb.texinfo (File): Mention that user has 'set trust-readonly-sections off' to get updated contents if they are modified. --- gdb/doc/gdb.texinfo | 5 ++++- gdb/testsuite/gdb.base/break-always.exp | 4 ++++ gdb/testsuite/gdb.mi/mi-fill-memory.exp | 5 +++++ 3 files changed, 13 insertions(+), 1 deletions(-) diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 21250fe..d8e4adf 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -16678,7 +16678,10 @@ The default is off. @item set trust-readonly-sections off Tell @value{GDBN} not to trust readonly sections. This means that the contents of the section might change while the program is running, -and must therefore be fetched from the target when needed. +and must therefore be fetched from the target when needed. If user +modified the code in the target program, user has to +@code{set trust-readonly-sections off} to guarantee @value{GDBN} reads +updated contents from the target program instead of object file. @item show trust-readonly-sections Show the current setting of trusting readonly sections. diff --git a/gdb/testsuite/gdb.base/break-always.exp b/gdb/testsuite/gdb.base/break-always.exp index b0a9faf..16f6d47 100644 --- a/gdb/testsuite/gdb.base/break-always.exp +++ b/gdb/testsuite/gdb.base/break-always.exp @@ -69,6 +69,10 @@ gdb_test "p /x \$shadow = *(char *) $bp_address" \ # and still leave the breakpoint insn planted. Try twice with # different values, in case we happen to be writting exactly what was # there already. +# Turn option "trust-readonly-sections" off to force GDB to read +# contents from the target instead of the object file. +gdb_test_no_output "set trust-readonly-sections off" + gdb_test "p /x *(char *) $bp_address = 0" \ " = 0x0" \ "write 0 to breakpoint's address" diff --git a/gdb/testsuite/gdb.mi/mi-fill-memory.exp b/gdb/testsuite/gdb.mi/mi-fill-memory.exp index 5f68cbb..ac9313b 100644 --- a/gdb/testsuite/gdb.mi/mi-fill-memory.exp +++ b/gdb/testsuite/gdb.mi/mi-fill-memory.exp @@ -51,6 +51,11 @@ mi_gdb_test "4-data-write-memory-bytes \$pc ab 8"\ "4\\\^done" \ "memory successfully filled (8 bytes)" +# Turn option "trust-readonly-sections" off to force GDB to read +# contents from the target instead of the object file. +mi_gdb_test "-gdb-set trust-readonly-sections off" "\\\^done" \ + "set trust-readonly-sections off" + mi_gdb_test "5-interpreter-exec console \"x \$pc\"" \ ".*0xabababab.*" \ "pattern correctly read from memory" -- 1.7.7.6