Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] New MI notification "=tsv-modified"
@ 2013-01-30 15:44 Yao Qi
  2013-01-30 17:17 ` Eli Zaretskii
  2013-02-01 20:38 ` Pedro Alves
  0 siblings, 2 replies; 10+ messages in thread
From: Yao Qi @ 2013-01-30 15:44 UTC (permalink / raw)
  To: gdb-patches

Hi,
I added MI notifications "=tsv-created" and "=tsv-deleted" in this
patch, http://sourceware.org/ml/gdb-patches/2012-09/msg00191.html
We think it is still necessary to add another MI notification
"=tsv-modified" for the changes of the initial value of a tsv.  This
is what this patch does.

gdb/doc:

2013-01-30  Yao Qi  <yao@codesourcery.com>

	* gdb.texinfo (GDB/MI Async Records): Document new MI
	notification '=tsv-modified'.
	* observer.texi (GDB Observers): New observer tsv_modified.
gdb:

2013-01-30  Yao Qi  <yao@codesourcery.com>

	* mi/mi-interp.c (mi_tsv_modified): Declare.
	(mi_interpreter_init): Call observer_attach_tsv_modified.
	(mi_tsv_modified): New.
	* tracepoint.c (trace_variable_command): Call
	observer_notify_tsv_modified if the initial value of tsv is
	changed.

	* NEWS: Mention the new MI notification.

gdb/testsuite:

2013-01-30  Yao Qi  <yao@codesourcery.com>

	* gdb.trace/mi-tsv-changed.exp (test_create_delete_tsv): Rename
	to ...
	(test_create_delete_modify_tsv): New.  New test on modifying
	the initial value of a tsv.
---
 gdb/NEWS                                   |    5 +++--
 gdb/doc/gdb.texinfo                        |    4 ++++
 gdb/doc/observer.texi                      |    5 +++++
 gdb/mi/mi-interp.c                         |   18 ++++++++++++++++++
 gdb/testsuite/gdb.trace/mi-tsv-changed.exp |   13 ++++++++++---
 gdb/tracepoint.c                           |    6 +++++-
 6 files changed, 45 insertions(+), 6 deletions(-)

diff --git a/gdb/NEWS b/gdb/NEWS
index 539ceb9..0e01deb 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -121,8 +121,9 @@ show print type typedefs
      "=cmd-param-changed".
   ** Trace frame changes caused by command "tfind" are now notified using
      new async record "=traceframe-changed".
-  ** The creation and deletion of trace state variables are now notified
-     using new async records "=tsv-created" and "=tsv-deleted".
+  ** The creation, deletion and modification of trace state variables
+     are now notified using new async records "=tsv-created",
+     "=tsv-deleted" and "=tsv-modified".
   ** The start and stop of process record are now notified using new
      async record "=record-started" and "=record-stopped".
   ** Memory changes are now notified using new async record
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 4b51228..b6b0439 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -27954,6 +27954,10 @@ value @var{value}.
 Reports that the trace state variable @var{name} is deleted or all
 trace state variables are deleted.
 
+@item =tsv-modified,name=@var{name},value=@var{value}
+Reports that the trace state variable @var{name} is modified with
+value @var{value}.
+
 @item =breakpoint-created,bkpt=@{...@}
 @itemx =breakpoint-modified,bkpt=@{...@}
 @itemx =breakpoint-deleted,id=@var{number}
diff --git a/gdb/doc/observer.texi b/gdb/doc/observer.texi
index 87c08e1..11fdc87 100644
--- a/gdb/doc/observer.texi
+++ b/gdb/doc/observer.texi
@@ -246,6 +246,11 @@ The trace state variable @var{name} is deleted.  If @var{name} is
 @code{NULL}, all trace state variables are deleted.
 @end deftypefun
 
+@deftypefun void tsv_modified (const char *@var{name}, LONGEST @var{value})
+The trace state value @var{name} is modified with value
+@var{value}.
+@end deftypefun
+
 @deftypefun void test_notification (int @var{somearg})
 This observer is used for internal testing.  Do not use.  
 See testsuite/gdb.gdb/observer.exp.
diff --git a/gdb/mi/mi-interp.c b/gdb/mi/mi-interp.c
index 6617647..c8ec3f1 100644
--- a/gdb/mi/mi-interp.c
+++ b/gdb/mi/mi-interp.c
@@ -73,6 +73,7 @@ static void mi_about_to_proceed (void);
 static void mi_traceframe_changed (int tfnum, int tpnum);
 static void mi_tsv_created (const char *name, LONGEST value);
 static void mi_tsv_deleted (const char *name);
+static void mi_tsv_modified (const char *name, LONGEST value);
 static void mi_breakpoint_created (struct breakpoint *b);
 static void mi_breakpoint_deleted (struct breakpoint *b);
 static void mi_breakpoint_modified (struct breakpoint *b);
@@ -137,6 +138,7 @@ mi_interpreter_init (struct interp *interp, int top_level)
       observer_attach_traceframe_changed (mi_traceframe_changed);
       observer_attach_tsv_created (mi_tsv_created);
       observer_attach_tsv_deleted (mi_tsv_deleted);
+      observer_attach_tsv_modified (mi_tsv_modified);
       observer_attach_breakpoint_created (mi_breakpoint_created);
       observer_attach_breakpoint_deleted (mi_breakpoint_deleted);
       observer_attach_breakpoint_modified (mi_breakpoint_modified);
@@ -594,6 +596,22 @@ mi_tsv_deleted (const char *name)
   gdb_flush (mi->event_channel);
 }
 
+/* Emit notification on modifying a trace state variable.  */
+
+static void
+mi_tsv_modified (const char *name, LONGEST value)
+{
+  struct mi_interp *mi = top_level_interpreter_data ();
+
+  target_terminal_ours ();
+
+  fprintf_unfiltered (mi->event_channel, "tsv-modified,"
+		      "name=\"%s\",value=\"%s\"\n",
+		      name, plongest (value));
+
+  gdb_flush (mi->event_channel);
+}
+
 /* Emit notification about a created breakpoint.  */
 
 static void
diff --git a/gdb/testsuite/gdb.trace/mi-tsv-changed.exp b/gdb/testsuite/gdb.trace/mi-tsv-changed.exp
index 4e7d5a4..03adbcb 100644
--- a/gdb/testsuite/gdb.trace/mi-tsv-changed.exp
+++ b/gdb/testsuite/gdb.trace/mi-tsv-changed.exp
@@ -23,9 +23,9 @@ if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
     return -1
 }
 
-# Test notifications on creating and deleting TSV.
+# Test notifications on creating, deleting and modifying TSV.
 
-proc test_create_delete_tsv { } {with_test_prefix "create delete" {
+proc test_create_delete_modify_tsv { } {with_test_prefix "create delete modify" {
     global binfile
     global decimal
 
@@ -37,6 +37,9 @@ proc test_create_delete_tsv { } {with_test_prefix "create delete" {
     mi_gdb_test "tvariable \$tvar1" \
 	".*=tsv-created,name=\"tvar1\",value=\"0\"\\\\n.*\\^done" \
 	"tvariable \$tvar1"
+    mi_gdb_test "tvariable \$tvar1 = 1" \
+	".*=tsv-modified,name=\"tvar1\",value=\"1\"\\\\n.*\\^done" \
+	"tvariable \$tvar1 modified"
     mi_gdb_test "tvariable \$tvar2 = 45" \
 	".*=tsv-created,name=\"tvar2\",value=\"45\"\\\\n.*\\^done" \
 	"tvariable \$tvar2"
@@ -81,6 +84,10 @@ proc test_upload_tsv { } { with_test_prefix "upload" {
     gdb_test "tvariable \$tvar2 = 45" \
 	"Trace state variable \\\$tvar2 created, with initial value 45." \
 	"Create a trace state variable with initial value"
+
+    gdb_test "tvariable \$tvar3 = 1" \
+	"Trace state variable \\\$tvar3 created, with initial value 1." \
+	"Create a trace state variable \$tvar3 with initial value 1"
     # Define a tracepoint otherwise tracing cannot be started.
     gdb_test "trace main" "Tracepoint $decimal at .*"
     gdb_test_no_output "tstart" "start trace experiment"
@@ -148,7 +155,7 @@ proc test_upload_tsv { } { with_test_prefix "upload" {
     set gdbserver_reconnect_p 0
 }}
 
- test_create_delete_tsv
+ test_create_delete_modify_tsv
 
 # Test target supports tracepoints or not.
 
diff --git a/gdb/tracepoint.c b/gdb/tracepoint.c
index be45cb4..8345ac6 100644
--- a/gdb/tracepoint.c
+++ b/gdb/tracepoint.c
@@ -408,7 +408,11 @@ trace_variable_command (char *args, int from_tty)
   tsv = find_trace_state_variable (internalvar_name (intvar));
   if (tsv)
     {
-      tsv->initial_value = initval;
+      if (tsv->initial_value != initval)
+	{
+	  tsv->initial_value = initval;
+	  observer_notify_tsv_modified (tsv->name, initval);
+	}
       printf_filtered (_("Trace state variable $%s "
 			 "now has initial value %s.\n"),
 		       tsv->name, plongest (tsv->initial_value));
-- 
1.7.7.6


^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-02-06 14:46 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-30 15:44 [PATCH] New MI notification "=tsv-modified" Yao Qi
2013-01-30 17:17 ` Eli Zaretskii
2013-02-01 20:38 ` Pedro Alves
2013-02-02  8:29   ` Yao Qi
2013-02-04 17:55     ` Pedro Alves
2013-02-05 15:05       ` Yao Qi
2013-02-05 15:41         ` Pedro Alves
2013-02-06 13:12           ` Yao Qi
2013-02-06 14:31             ` Pedro Alves
2013-02-06 14:46               ` Yao Qi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox