From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32337 invoked by alias); 6 Feb 2013 14:31:33 -0000 Received: (qmail 32324 invoked by uid 22791); 6 Feb 2013 14:31:32 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Feb 2013 14:31:21 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r16EVJu1015284 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Feb 2013 09:31:19 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r16EVI2J030759; Wed, 6 Feb 2013 09:31:18 -0500 Message-ID: <51126935.6090501@redhat.com> Date: Wed, 06 Feb 2013 14:31:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH] New MI notification "=tsv-modified" References: <1359560580-1970-1-git-send-email-yao@codesourcery.com> <510C27CE.3090102@redhat.com> <510CCE26.50600@codesourcery.com> <510FF037.8000101@redhat.com> <51111F75.1020007@codesourcery.com> <51112835.1010303@redhat.com> <51125685.4050406@codesourcery.com> In-Reply-To: <51125685.4050406@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00139.txt.bz2 On 02/06/2013 01:11 PM, Yao Qi wrote: > gdb: > > 2013-02-06 Yao Qi > > * mi/mi-interp.c: Include "tracepoint.h". > (mi_tsv_modified): Declare. > (mi_tsv_created, mi_tsv_deleted): Update declaration. > (mi_interpreter_init): Call observer_attach_tsv_modified. > (mi_tsv_modified): New. > (mi_tsv_created, mi_tsv_deleted): Update. > * tracepoint.c (trace_variable_command): Call > observer_notify_tsv_modified if the initial value of tsv is > changed. > (delete_trace_state_variable): Call > observer_notify_tsv_deleted earlier. > (trace_variable_command): Caller update. > (create_tsv_from_upload): Likewise. > * observer.sh: Declare "struct trace_state_variable". > > gdb/testsuite: > > 2013-02-06 Yao Qi > > * gdb.trace/mi-tsv-changed.exp (test_create_delete_tsv): Rename > to ... > (test_create_delete_modify_tsv): ... here. New test on modifying > the initial value of a tsv. Thanks. These parts are OK. -- Pedro Alves