Re: [PATCH] New MI notification "=tsv-modified"

[Pedro Alves <palves@redhat.com>]

On 02/05/2013 03:04 PM, Yao Qi wrote:
> On 02/05/2013 01:30 AM, Pedro Alves wrote:
>> _Which_  value is being talked about here is not explicit.
>> Trace state variables have_two_  values.  The initial value,
>> and the current value (omitted if doesn't exist yet).
> 
> I meant the initial value here.
> 
>> If we list tsvs with MI's -trace-list-variables, we'll indeed
>> see an "init" and a "current" attribute, for each tsv, and no
>> attribute named "value".  So I think it'd be very good to fix this
>> before the release, and make the output of the notifications
>> consistent with the tsv listing output, and the docs clearer.
>>
>> E.g.:
>> (gdb) interpreter-exec mi "-trace-list-variables"
>> ^done,trace-variables={nr_rows="1",nr_cols="3",
>>                         hdr=[{width="15",alignment="-1",col_name="name",colhdr="Name"},
>>                              {width="11",alignment="-1",col_name="initial",colhdr="Initial"},
>>                              {width="11",alignment="-1",col_name="current",colhdr="Current"}],
>>                         body=[variable={name="$a",initial="1"},
>>                               variable={name="$b",initial="2",current="3"}]
>>
>> SO IOW, =tsv-created should be
>>
>>   =tsv-created,name=@var{name},initial=@var{value}
>>
>> instead of the current
>>
>>   =tsv-created,name=@var{name},value=@var{value}
>>
>>
>> and =tsv-modified should be
>>
>>   =tsv-modified,name=@var{name},initial=@var{value}
>>
>> instead of the proposed
>>
>>   =tsv-modified,name=@var{name},value=@var{value}
> 
> The patch below implements these MI notifications with suggested 
> attributes.  "=tsv-modified" is implemented like:
> 
> =tsv-modified,name=@var{name},initial=@var{initial},current=@var{current}
> 
> I don't refactor function tvariables_info_1 in this patch, and I'd like 
> to defer this change to next one.
> 
> Is it OK if no test regression?

I think that even without refactoring, we should
do what tvariables_info_1 does and omit "current" if the value
is not known.  The -trace-list-variables docs explain this
suppression -- we should probably copy that bit into the
notification docs.

-- 
Pedro Alves