Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 0/6] Add a new field 'installed' when reporting tracepoint
Date: Tue, 04 Dec 2012 04:45:00 -0000	[thread overview]
Message-ID: <1354596282-32526-1-git-send-email-yao@codesourcery.com> (raw)

Hello,
During the review to 'tracepoint download' notification
<http://sourceware.org/ml/gdb-patches/2012-11/msg00871.html>, we find it is
better to treat 'installed on target' as an attribute of a tracepoint,
and breakpoint related notification can report it, instead of a
separate notification.

In this patch series, we add a field 'installed' in
print_one_breakpoint_location, which is a boolean to show "y" or "n" the
tracepoint is installed on target.  The field reflects the value of
'inserted' field of each location.

Originally, my proposal is for MI notification, but I think it also
useful to display the state of 'installed' in the output of CLI.  With
this series applied, we can see the 'installed' state in both CLI and
MI.

The 'installed' field is not shown for non-tracepoint breakpoint,
because in most of cases, breakpoints are inserted when to resume
inferior, and removed when inferior stops.

1/6  Add a field 'installed' for each location of tracepoint.
2/6  Iterate over ALL_TRACEPOINTS first.
3/6  Notify breakpoint-modified when tracepoints are downloaded.
4/6  Notify breakpoint-modified when uploaded tracepoints are merged.
5/6  Test tracepoints are installed or not
6/6  Update test cases for 'installed' field.

Patch 1/6 adds the new field 'installed' in
print_one_breakpoint_location, and patch 2/6 - 4/6 call
breakpoint-modified observer when the 'inserted' flag is changed.  Patch
5/6 is to test this feature, and patch 6/6 is update existing tests for
the new output of 'info breakpoint' or 'info tracepoint'.

The whole series are tested on x86_linux both native and gdbserver.  Is
it OK?

 gdb/breakpoint.c                                  |   48 ++++++++++++++-------
 gdb/testsuite/gdb.trace/actions.exp               |   25 +++++++++--
 gdb/testsuite/gdb.trace/change-loc.exp            |    6 ++-
 gdb/testsuite/gdb.trace/deltrace.exp              |   22 +++++++--
 gdb/testsuite/gdb.trace/infotrace.exp             |   10 +++-
 gdb/testsuite/gdb.trace/mi-traceframe-changed.exp |    3 +-
 gdb/testsuite/gdb.trace/mi-tracepoint-changed.exp |   20 +++++++-
 gdb/testsuite/gdb.trace/passcount.exp             |   28 +++++++++---
 gdb/testsuite/gdb.trace/tracecmd.exp              |   13 ++++--
 gdb/testsuite/gdb.trace/while-stepping.exp        |    3 +-
 gdb/tracepoint.c                                  |   33 ++++++++++++++
 11 files changed, 163 insertions(+), 48 deletions(-)

-- 
1.7.7.6


             reply	other threads:[~2012-12-04  4:45 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-04  4:45 Yao Qi [this message]
2012-12-04  4:45 ` [PATCH 3/6] Notify breakpoint-modified when tracepoints are downloaded Yao Qi
2012-12-06 20:56   ` Pedro Alves
2012-12-04  4:45 ` [PATCH 5/6] Test tracepoints are installed or not Yao Qi
2012-12-07 12:39   ` Pedro Alves
2012-12-07 13:55     ` Yao Qi
2012-12-07 14:20       ` Pedro Alves
2012-12-09 12:53         ` Yao Qi
2012-12-11 17:53           ` Pedro Alves
2012-12-12  2:59             ` Yao Qi
2012-12-12 12:24               ` Pedro Alves
2012-12-12 15:00                 ` Yao Qi
2012-12-04  4:45 ` [PATCH 4/6] Notify breakpoint-modified when uploaded tracepoints are merged Yao Qi
2012-12-06 20:57   ` Pedro Alves
2012-12-04  4:45 ` [PATCH 1/6] Add a field 'installed' for each location of tracepoint Yao Qi
2012-12-06 20:56   ` Pedro Alves
2012-12-07 13:49     ` Yao Qi
2012-12-09 12:49     ` Yao Qi
2012-12-09 16:57       ` Eli Zaretskii
2012-12-11 17:26       ` Pedro Alves
2012-12-12  1:54         ` Yao Qi
2012-12-12 12:03           ` Pedro Alves
2012-12-04  4:45 ` [PATCH 2/6] Iterate over ALL_TRACEPOINTS first Yao Qi
2012-12-06 20:56   ` Pedro Alves
2012-12-04  4:45 ` [PATCH 6/6] Update test cases for 'installed' field Yao Qi
2012-12-07 12:42   ` Pedro Alves
2012-12-13 12:07     ` Yao Qi
2012-12-13 17:13       ` Pedro Alves
2012-12-06 20:55 ` [PATCH 0/6] Add a new field 'installed' when reporting tracepoint Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354596282-32526-1-git-send-email-yao@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox