From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/6] Iterate over ALL_TRACEPOINTS first.
Date: Thu, 06 Dec 2012 20:56:00 -0000 [thread overview]
Message-ID: <50C10685.50108@redhat.com> (raw)
In-Reply-To: <1354596282-32526-3-git-send-email-yao@codesourcery.com>
On 12/04/2012 04:44 AM, Yao Qi wrote:
> Hi,
> The 'breakpoint-modified' observer is notified on the breakpoint
> level, in order to notify observer for a given tracepoint only once,
> we change to iterate over tracepoint first, and then iterate over
> locations of each tracepoint. In the inner loop, when we find a
> tracepoint location is downloaded, we mark a flag, and notify the
> observer in outer loop (on tracepoints) if flag is true. In short, we
> change the iteration from:
>
> ALL_BP_LOCATIONS (bl, blp_tmp)
> {
> if (!is_tracepoint (bl->owner))
> continue;
> }
>
> to:
>
> ALL_TRACEPOINTS (b)
> {
> for (bl = b->loc; bl; bl = bl->next)
> {}
> }
>
> download_tracepoint_locations is called after breakpoint re-setting,
> so I think this change has no functional affect.
Yes, I think so too, because tracepoint locations are never duplicates
(otherwise this would be a problem).
OK.
--
Pedro Alves
next prev parent reply other threads:[~2012-12-06 20:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 4:45 [PATCH 0/6] Add a new field 'installed' when reporting tracepoint Yao Qi
2012-12-04 4:45 ` [PATCH 3/6] Notify breakpoint-modified when tracepoints are downloaded Yao Qi
2012-12-06 20:56 ` Pedro Alves
2012-12-04 4:45 ` [PATCH 5/6] Test tracepoints are installed or not Yao Qi
2012-12-07 12:39 ` Pedro Alves
2012-12-07 13:55 ` Yao Qi
2012-12-07 14:20 ` Pedro Alves
2012-12-09 12:53 ` Yao Qi
2012-12-11 17:53 ` Pedro Alves
2012-12-12 2:59 ` Yao Qi
2012-12-12 12:24 ` Pedro Alves
2012-12-12 15:00 ` Yao Qi
2012-12-04 4:45 ` [PATCH 4/6] Notify breakpoint-modified when uploaded tracepoints are merged Yao Qi
2012-12-06 20:57 ` Pedro Alves
2012-12-04 4:45 ` [PATCH 1/6] Add a field 'installed' for each location of tracepoint Yao Qi
2012-12-06 20:56 ` Pedro Alves
2012-12-07 13:49 ` Yao Qi
2012-12-09 12:49 ` Yao Qi
2012-12-09 16:57 ` Eli Zaretskii
2012-12-11 17:26 ` Pedro Alves
2012-12-12 1:54 ` Yao Qi
2012-12-12 12:03 ` Pedro Alves
2012-12-04 4:45 ` [PATCH 2/6] Iterate over ALL_TRACEPOINTS first Yao Qi
2012-12-06 20:56 ` Pedro Alves [this message]
2012-12-04 4:45 ` [PATCH 6/6] Update test cases for 'installed' field Yao Qi
2012-12-07 12:42 ` Pedro Alves
2012-12-13 12:07 ` Yao Qi
2012-12-13 17:13 ` Pedro Alves
2012-12-06 20:55 ` [PATCH 0/6] Add a new field 'installed' when reporting tracepoint Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C10685.50108@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox