From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 3/6] Notify breakpoint-modified when tracepoints are downloaded.
Date: Tue, 04 Dec 2012 04:45:00 -0000 [thread overview]
Message-ID: <1354596282-32526-4-git-send-email-yao@codesourcery.com> (raw)
In-Reply-To: <1354596282-32526-1-git-send-email-yao@codesourcery.com>
When any location of a tracepoint is downloaded, notify
'breakpoint-modified' observer.
gdb:
2012-12-03 Yao Qi <yao@codesourcery.com>
* breakpoint.c (download_tracepoint_locations): Notify
'breakpoint-modified' observer if any tracepoint location is
downloaded.
* tracepoint.c (start_tracing): Likewise.
---
gdb/breakpoint.c | 4 ++++
gdb/tracepoint.c | 5 +++++
2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 3f2f0c9..56eeb35 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -12090,6 +12090,7 @@ download_tracepoint_locations (void)
{
struct bp_location *bl;
struct tracepoint *t;
+ int bp_location_downloaded = 0;
if ((b->type == bp_fast_tracepoint
? !may_insert_fast_tracepoints
@@ -12109,9 +12110,12 @@ download_tracepoint_locations (void)
target_download_tracepoint (bl);
bl->inserted = 1;
+ bp_location_downloaded = 1;
}
t = (struct tracepoint *) b;
t->number_on_target = b->number;
+ if (bp_location_downloaded)
+ observer_notify_breakpoint_modified (b);
}
do_cleanups (old_chain);
diff --git a/gdb/tracepoint.c b/gdb/tracepoint.c
index 912341a..c467b9c 100644
--- a/gdb/tracepoint.c
+++ b/gdb/tracepoint.c
@@ -1767,6 +1767,7 @@ start_tracing (char *notes)
{
struct tracepoint *t = (struct tracepoint *) b;
struct bp_location *loc;
+ int bp_location_downloaded = 0;
/* Clear `inserted' flag. */
for (loc = b->loc; loc; loc = loc->next)
@@ -1788,6 +1789,7 @@ start_tracing (char *notes)
target_download_tracepoint (loc);
loc->inserted = 1;
+ bp_location_downloaded = 1;
}
t->number_on_target = b->number;
@@ -1795,6 +1797,9 @@ start_tracing (char *notes)
for (loc = b->loc; loc; loc = loc->next)
if (loc->probe != NULL)
loc->probe->pops->set_semaphore (loc->probe, loc->gdbarch);
+
+ if (bp_location_downloaded)
+ observer_notify_breakpoint_modified (b);
}
VEC_free (breakpoint_p, tp_vec);
--
1.7.7.6
next prev parent reply other threads:[~2012-12-04 4:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 4:45 [PATCH 0/6] Add a new field 'installed' when reporting tracepoint Yao Qi
2012-12-04 4:45 ` [PATCH 5/6] Test tracepoints are installed or not Yao Qi
2012-12-07 12:39 ` Pedro Alves
2012-12-07 13:55 ` Yao Qi
2012-12-07 14:20 ` Pedro Alves
2012-12-09 12:53 ` Yao Qi
2012-12-11 17:53 ` Pedro Alves
2012-12-12 2:59 ` Yao Qi
2012-12-12 12:24 ` Pedro Alves
2012-12-12 15:00 ` Yao Qi
2012-12-04 4:45 ` [PATCH 4/6] Notify breakpoint-modified when uploaded tracepoints are merged Yao Qi
2012-12-06 20:57 ` Pedro Alves
2012-12-04 4:45 ` [PATCH 1/6] Add a field 'installed' for each location of tracepoint Yao Qi
2012-12-06 20:56 ` Pedro Alves
2012-12-07 13:49 ` Yao Qi
2012-12-09 12:49 ` Yao Qi
2012-12-09 16:57 ` Eli Zaretskii
2012-12-11 17:26 ` Pedro Alves
2012-12-12 1:54 ` Yao Qi
2012-12-12 12:03 ` Pedro Alves
2012-12-04 4:45 ` [PATCH 2/6] Iterate over ALL_TRACEPOINTS first Yao Qi
2012-12-06 20:56 ` Pedro Alves
2012-12-04 4:45 ` [PATCH 6/6] Update test cases for 'installed' field Yao Qi
2012-12-07 12:42 ` Pedro Alves
2012-12-13 12:07 ` Yao Qi
2012-12-13 17:13 ` Pedro Alves
2012-12-04 4:45 ` Yao Qi [this message]
2012-12-06 20:56 ` [PATCH 3/6] Notify breakpoint-modified when tracepoints are downloaded Pedro Alves
2012-12-06 20:55 ` [PATCH 0/6] Add a new field 'installed' when reporting tracepoint Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354596282-32526-4-git-send-email-yao@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox