From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7925 invoked by alias); 4 Dec 2012 04:45:14 -0000 Received: (qmail 7859 invoked by uid 22791); 4 Dec 2012 04:45:12 -0000 X-SWARE-Spam-Status: No, hits=-3.7 required=5.0 tests=AWL,BAYES_00,FROM_12LTRDOM,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Dec 2012 04:45:03 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TfkNS-0006qa-G5 from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Mon, 03 Dec 2012 20:45:02 -0800 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 3 Dec 2012 20:45:02 -0800 Received: from qiyao.dyndns.org.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Mon, 3 Dec 2012 20:45:01 -0800 From: Yao Qi To: Subject: [PATCH 0/6] Add a new field 'installed' when reporting tracepoint Date: Tue, 04 Dec 2012 04:45:00 -0000 Message-ID: <1354596282-32526-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00047.txt.bz2 Hello, During the review to 'tracepoint download' notification , we find it is better to treat 'installed on target' as an attribute of a tracepoint, and breakpoint related notification can report it, instead of a separate notification. In this patch series, we add a field 'installed' in print_one_breakpoint_location, which is a boolean to show "y" or "n" the tracepoint is installed on target. The field reflects the value of 'inserted' field of each location. Originally, my proposal is for MI notification, but I think it also useful to display the state of 'installed' in the output of CLI. With this series applied, we can see the 'installed' state in both CLI and MI. The 'installed' field is not shown for non-tracepoint breakpoint, because in most of cases, breakpoints are inserted when to resume inferior, and removed when inferior stops. 1/6 Add a field 'installed' for each location of tracepoint. 2/6 Iterate over ALL_TRACEPOINTS first. 3/6 Notify breakpoint-modified when tracepoints are downloaded. 4/6 Notify breakpoint-modified when uploaded tracepoints are merged. 5/6 Test tracepoints are installed or not 6/6 Update test cases for 'installed' field. Patch 1/6 adds the new field 'installed' in print_one_breakpoint_location, and patch 2/6 - 4/6 call breakpoint-modified observer when the 'inserted' flag is changed. Patch 5/6 is to test this feature, and patch 6/6 is update existing tests for the new output of 'info breakpoint' or 'info tracepoint'. The whole series are tested on x86_linux both native and gdbserver. Is it OK? gdb/breakpoint.c | 48 ++++++++++++++------- gdb/testsuite/gdb.trace/actions.exp | 25 +++++++++-- gdb/testsuite/gdb.trace/change-loc.exp | 6 ++- gdb/testsuite/gdb.trace/deltrace.exp | 22 +++++++-- gdb/testsuite/gdb.trace/infotrace.exp | 10 +++- gdb/testsuite/gdb.trace/mi-traceframe-changed.exp | 3 +- gdb/testsuite/gdb.trace/mi-tracepoint-changed.exp | 20 +++++++- gdb/testsuite/gdb.trace/passcount.exp | 28 +++++++++--- gdb/testsuite/gdb.trace/tracecmd.exp | 13 ++++-- gdb/testsuite/gdb.trace/while-stepping.exp | 3 +- gdb/tracepoint.c | 33 ++++++++++++++ 11 files changed, 163 insertions(+), 48 deletions(-) -- 1.7.7.6