Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFC] Update description of parse_breakpoint_sals
@ 2011-02-04 17:33 Thiago Jung Bauermann
  2011-02-06  7:23 ` Joel Brobecker
  0 siblings, 1 reply; 3+ messages in thread
From: Thiago Jung Bauermann @ 2011-02-04 17:33 UTC (permalink / raw)
  To: gdb-patches ml

Hi,

The comment describing parse_breakpoint_sals is outdated. This patch
updates it and expands it a bit. I was tempted to just commit it as
obvious, but people more familiar with the function may have something
to add or comment to my new description...
-- 
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center


2011-02-04  Thiago Jung Bauermann  <bauerman@br.ibm.com>

	* breakpoint.c (parse_breakpoint_sals): Fix description.

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 656dedd..39d9b02 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -7485,10 +7485,13 @@ create_breakpoints_sal (struct gdbarch *gdbarch,
     }
 }
 
-/* Parse ARG which is assumed to be a SAL specification possibly
+/* Parse ADDRESS which is assumed to be a SAL specification possibly
    followed by conditionals.  On return, SALS contains an array of SAL
    addresses found.  ADDR_STRING contains a vector of (canonical)
-   address strings.  ARG points to the end of the SAL.  */
+   address strings.  ADDRESS points to the end of the SAL.
+
+   The array and the line spec strings are allocated on the heap, it is
+   the caller's responsibility to free them.  */
 
 static void
 parse_breakpoint_sals (char **address,



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-02-07 13:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-04 17:33 [RFC] Update description of parse_breakpoint_sals Thiago Jung Bauermann
2011-02-06  7:23 ` Joel Brobecker
2011-02-07 13:40   ` Thiago Jung Bauermann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox